feat: adding typescript and new imports to the project by YoelFerreyra · Pull Request #112 · TeamNovaSoft/novabot

YoelFerreyra · 2025-02-06T15:24:07Z

No description provided.

.gitignore

package.json

src/config.ts

src/deploy-commands.js

src/deploy-events.js

heliomar-pena · 2025-02-06T20:27:54Z

src/index.ts

  client.commands = new Collection();
  deployCommands(client);
-  deployEvents(client);
+  //deployEvents(client);


Did you miss to uncomment this function?

heliomar-pena · 2025-02-06T20:28:27Z

src/index.ts

 }

-function handleCriticalError(error) {
+function handleCriticalError(error: any) {


Maybe Error is a better interface for this:

Suggested change

function handleCriticalError(error: any) {

function handleCriticalError(error: Error) {

please take a look at this comment

src/types/config.types.ts

heliomar-pena · 2025-02-06T20:29:35Z

src/utils/log-error.js

+import path from 'path';

-const logDir = path.join(__dirname, '../log');
+const logDir = path.join(import.meta.url, '../log'); // Cambié __dirname por import.meta.url, ya que en módulos ES no tienes acceso a __dirname


Remove this comment and add it to the PR description instead

heliomar-pena

Uf great work man!

heliomar-pena · 2025-02-10T13:01:53Z

src/config.ts

+dotenv.config();
+import { parseAllowedChannels } from './csv-parser-allowed-channels.ts'
+import path from 'path'
+import type { CronScheduleReview, DiscordServer, GeminiIntegration, MappedStatusCommands, PrTemplate, QAMention, RequestPoint, ScheduleCalendar, ScheduleMessages, TimeZone, VotePoints } from './types/config.d.js';


creo que los archivos de definicion de tipos deben ser .ts y no .js

heliomar-pena · 2025-02-10T13:04:28Z

src/cron/utils/read-markdown-messages.ts

 };

+interface ParsedSchedule {
+  variables: Record<string, string>;


I think here you are defining parameters of parseMarkdownSchedule, and variables is not a parameter of this function

heliomar-pena · 2025-02-10T13:05:37Z

src/cron/utils/read-markdown-messages.ts

+ * @param client - Client object.
 */
-const processMarkdownFiles = (client) => {
+export const processMarkdownFiles = (client: unknown): void => {


Discord doesn't have a type definition for client?

heliomar-pena · 2025-02-10T13:08:04Z

src/deploy-commands.js

      .filter((file) => file.endsWith('.js'));
    for (const file of commandFiles) {
-      const command = require(path.join(commandsPath, file));
+      const command = await import(path.join(commandsPath, file));


Sometimes dynamic import give problems in the build, have you tried the build to see if there is not error?

heliomar-pena · 2025-02-10T13:08:20Z

src/deploy-commands.js

      } else {
        console.log(
-          `[WARNING] The command at ${filePath} is missing a required "data" or "execute" property.`
+          `[WARNING] The command at is missing a required "data" or "execute" property.`


missed file path in the error message

heliomar-pena · 2025-02-10T13:08:46Z

src/deploy-commands.ts

@@ -0,0 +1,73 @@
+import { REST, Routes, Client } from 'discord.js';


Here is the Client discord's type, you can use it in here: https://github.com/TeamNovaSoft/novabot/pull/112/files#r1949021235

heliomar-pena · 2025-02-10T13:09:47Z

src/index.ts

+import { processMarkdownFiles } from './cron/utils/read-markdown-messages.ts';
+import { scheduleReviewCheck } from './cron/schedule-code-review.ts';
+
+


extra space can be removed

Suggested change

heliomar-pena · 2025-02-10T13:12:24Z

src/languages/index.ts

+const translationsPath: string = path.join(
+  path.dirname(new URL(import.meta.url).pathname),
+  'translations'
+);


maybe we could use process.cwd() instead of path.dirname(new URL(import.meta.url).pathname),?, I am not sure we should test it

Israel-Laguan · 2025-02-13T15:45:02Z

Check for rebase

feat: adding typescript and new imports to the project

fda4a1e

YoelFerreyra self-assigned this Feb 6, 2025

YoelFerreyra added 2 commits February 6, 2025 12:40

fix: style of code for prettier

dc8d593

fix: tsconfig file

c0d182b