Circuit extraction from GraphState #46
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: Sync with latest updates from mf
Collaborator
|
I changed the base branch from |
EarlMilktea
requested changes
Jul 1, 2025
| depth: int, | ||
| rng: np.random.Generator | None = None, | ||
| edge_p: float = 0.5, | ||
| angle_list: list | None = None, |
Collaborator
There was a problem hiding this comment.
Please use an appropriate collections.abc stuff rather than list .
| depth: int, | ||
| rng: np.random.Generator | None = None, | ||
| edge_p: float = 0.5, | ||
| angle_list: list | None = None, |
Collaborator
There was a problem hiding this comment.
_list is unnecessary because it's obvious that it should be list from the annotation.
| generated MBQC circuit | ||
| """ | ||
| if rng is None: | ||
| rng = np.random.default_rng() |
Collaborator
There was a problem hiding this comment.
MEMO: it's better to cache rng as in graphix, because PRNG is designed to reduce correlations between samples drawn from the same generator instance.
| self.pivot(*pair) | ||
| del pair | ||
| continue | ||
| if u := self._extract_xz_node(): |
Collaborator
There was a problem hiding this comment.
is None is preferable because 0 is also falthy.
| assert _is_close_angle(result_basis.angle, ref_angle) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("plane", [Plane.XY, Plane.YZ, Plane.XZ]) |
Collaborator
There was a problem hiding this comment.
You can directly iterate Plane as list(Plane) .
| dict[int, int] | ||
| inner index to node index mapping. | ||
| """ | ||
| return self.__inner2nodes |
Collaborator
There was a problem hiding this comment.
Is it OK to expose internal states?
| n, m = M.shape | ||
| row_ops: List[Tuple[int,int]] = [] | ||
| pivot_row = 0 | ||
| for col in range(m): |
| _process_frontier(d, frontier, circ) | ||
|
|
||
|
|
||
| def _gauss_elim(M: np.ndarray) -> Tuple[np.ndarray, List[Tuple[int,int]]]: |
| @@ -0,0 +1,161 @@ | |||
| from typing import Set, List, Tuple | |||
| def test_prune_non_cliffords( | ||
| zx_graph: ZXGraphState, | ||
| initial_zxgraph: tuple[range, set[tuple[int, int]]], | ||
| measurements: list[tuple[int, Plane, float]], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please check the following:
pytest)ruffmypyandpyrightmake htmlin./docs/- you may need to install dependency for sphinx docs, seedocs/requirements.txt.)Then, please fill in below:
Context (if applicable):
Implement circuit extraction algorithm in Backens et al (2021)
Description of the change:
Related issue:
#32