Fix CME in Client Setup and Incompatibility with Shield Expansion#166
Open
evanbones wants to merge 5 commits intoTeamGalena:1.20.xfrom
Open
Fix CME in Client Setup and Incompatibility with Shield Expansion#166evanbones wants to merge 5 commits intoTeamGalena:1.20.xfrom
evanbones wants to merge 5 commits intoTeamGalena:1.20.xfrom
Conversation
evanbones
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FMLClientSetupEvent runs in parallel and ItemProperties.register and ItemBlockRenderTypes.setRenderLayer aren't thread-safe, causing this semi-infrequent crash:
https://mclo.gs/aCfIKMH
Wrapping these calls in
event.enqueueWork()ensures they run safely on the main threadThe Shield Expansion incompatibility was caused by changes to internals, simply compiling against the latest version of Shield Expansion fixes it.
Closes #172
Might also close #25