Fix home carousel id assignment #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
uniqidusage and potential caching/duplicate id issues.Description
hookDisplayHomewith$carouselId = 'everpsblog-home-slider-' . uniqid('', true);and assign it to Smarty ascarousel_idineverpsblog.php.{assign var=carousel_id value='everpsblog-home-slider-'|cat:uniqid()}fromviews/templates/hook/home.tpland use the assigned{$carousel_id}directly.everpsblog.phpandviews/templates/hook/home.tplto centralize id generation in PHP.Testing
Fix home carousel id assignment.Codex Task