Heroe carousel: advance one slide per click and respect loop/nav state #892
+46
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
data-loopsetting and surface arrow availability for predictable non-loop behavior.Description
updateSlides()to align toindex * slideWidthand clamp it withmaxOffsetso each arrow click moves one slide width.loop = carousel.dataset.loop !== '0'and addupdateNavState()to enable/disable previous/next buttons and setaria-disabledappropriately when not looping.goNext()/goPrev()whenloopis false and compute.is-prev/.is-nextclasses separately for loop vs non-loop modes.currentColorwhile removing some hardcoded background/colors in the carousel CSS.Testing
php -S 0.0.0.0:8000 -t ., which started successfully.Codex Task