(partial?) fix for issue 1149 #1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(partial?) fix for issue TeamCOMPAS#1149 - remove conditional from TPAGB::IsSupernova()
jeffriley
added
bug
ilyamandel
approved these changes
Jan 17, 2025
Collaborator
ilyamandel
left a comment
ilyamandel
left a comment
There was a problem hiding this comment.
Thank you for the quick fix, @jeffriley !
Will return to #1149 later, but agree that this is a necessary and urgent fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(partial?) fix for issue #1149 - remove conditional from TPAGB::IsSupernova(). Whether it fixes issue 1149 completely or not, the conditional shouldn't be there...
See #1149 for details
@ilyamandel if you think this fixes #1149 completely go ahead and close it.