Skip to content

Conversation

@ilyamandel
Copy link
Collaborator

See discussion and plots in #1285 .

  • The nuclear timescale mass transfer rate is now set by the requirement that the star ends the time step just filling its Roche lobe (addresses issue Misbehaving nuclear timescale mass transfer #1285)
  • Fix an issue with the root finder for fitting into the RL that led to artificial failures to find a root
  • Fix issue (likely introduced in 03.08.00) with the accretor not gaining mass appropriately

Copy link
Collaborator

@jeffriley jeffriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - thanks @ilyamandel

@ilyamandel
Copy link
Collaborator Author

Thanks, @jeffriley . Given that this has multiple fixes for pretty severe bugs (e.g., the secondary was not accreting when it should have been), I'll go ahead and merge. Folks tagged in this are aware and can comment at their convenience if they wish (also tagging @veome22 , since he will probably want to use v. 3.09.00 for future tests).

@ilyamandel ilyamandel merged commit a4a499c into dev Nov 25, 2024
2 checks passed
@ilyamandel ilyamandel deleted the MTFix branch November 25, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants