-
Notifications
You must be signed in to change notification settings - Fork 51
Added enders cataclysm trofers #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I18n the modpack (TeamAOF#648)
|
This could be much more compact, likely even just one file, making this easier to maintain too. The idea is to have simple data structure, grouping each trofer's details together, then have a custom function loop over that, building up and adding each trofer. You can see examples of this idea elsewhere in the kubejs scripts. |
|
I can easily convert it if preferred. I followed the Trofers guidelines and kept it in pure datapack format so it would also work without KubeJS. |
|
That'd be sweet, imo, if you can do the compact option. |
| }, | ||
| "name": { | ||
| "color": "#c890f0", | ||
| "translate": "trophy.trofers.composed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, you only created the translation key here, but you didn't write it into the language file. I think this may be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

I've added all ender's cataclysm enemy trofers and loot table, the netherie monstrosity and the scylla has some problem but i'm trying to contact the mod creator to fix them.

