Code cleanup

[PillageDev]

Kinematics.java

• leftEncoderPostion -> leftEncoderPosition
• Made distance variable inline
• Simplified atPose() if statement

Autobalance.java

• INTERGRAL_LIMIT -> INTEGRAL_LIMIT

Rotate.java

• initalAngle -> initialAngle

Arm.java

• Removed unnecessary *1 and /1
• Simplified if statements

WriteToCSV.java

• simplified if statement

[bjmcternan]

Nice work. A few fixes and some stuff to think about.

[bjmcternan]

One more

[bjmcternan]

One more

[bjmcternan]

Nice work

[bjmcternan]

Poke someone else on the team to review it tomorrow so you can merge it

[PillageDev]

Yea anand is reviewing tomorrow he said

[NathanEdg]

Will we ever not use booleans? Like teach the other members about the non boolean methods

[LavaWaffle]

Could you clarify what you mean by not use booleans? Are you talking in terms of comparison and using strings with .equals?

[NathanEdg]

Yea or not using == true rather than like

if (someVar) {} in substitute for

if (someVar == true) {}

or

if (!someVar) {}

rather than

if (someVar == false) {}

[LavaWaffle]

We should make sure everyone knows that you can simply just write if (var) instead of if (true == var), but in our code we should stick to true == and false == for readability.

[NathanEdg]

Yea

[bjmcternan]

Readability is a great reason but there's another one:
In Java this is not an issue, but in some languages if(foo = 10) will assign foo a value of 10 and be TRUE.
This is the case for C. Check it out: https://onlinegdb.com/RS9imtWX2

if(10 = foo) will result in a compilation error which is better than chasing a single character logic issue. Just a good idea to get in the habit of defensive programming.

[LavaWaffle]

Looks good!

[NathanEdg]

bjmcternan I think it requires your review again