Merged
Conversation
단순히 Supabase 테이블과 JSON 파일 네임 미스매칭 문제였습니다.
프로젝트 컨벤션에 맞게 변경했습니다.
- 토스트에 타이밍 문제가 있는 것 같습니다. 토스트를 먼저 보이고, 그 이후에 버튼 액션을 실행하면 pop이 제대로 되지 않아 뷰에 갇히게 됩니다. - 현재 코드에서 직접적으로 체감할 수 있는 문제는 없습니다.
kelly-chui
commented
Apr 9, 2025
| imageData: profileImage?.jpegData(compressionQuality: 0.7) | ||
| ) | ||
| } catch { | ||
| SNMLogger.error(error.localizedDescription) |
Contributor
Author
There was a problem hiding this comment.
SNMErrorHandler로 하려 했는데, 이건 일괄 처리하는게 좋을 것 같아서 Logger로 냅뒀습니다. 이 소스 파일 내부에서도 현재 이슈랑 맞지 않는 변경사항들이 늘어나는 것 같아서요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔖 Issue Number
close #75
📙 작업 내역
Taskpresenter로 옮기고 코드 리더빌리티 약간 향상if let을 써야할 부분에guard let을 쓴 것을 수정했습니다.📝 PR 특이사항
👻 레퍼런스