Conversation
fix: JoinRoom 비밀번호 검증 조건 및 응답 형식 개선
refactor: Claude 설정 구조 재편 및 API 응답 형식 통일
This reverts commit 3cdb670.
…-Pull-server into refactor/claude
chore: 빌드 인프라 및 마이그레이션 구조 재정비
chore: Docker Compose 기반 배포 파이프라인 구성
There was a problem hiding this comment.
Code Review
This pull request refactors the project by introducing comprehensive Claude and Gemini rules, updating automation hooks, and standardizing the C# codebase. Key improvements include the systematic addition of CancellationToken support across services and repositories, the adoption of CommonApiResponse for consistent API responses, and the implementation of rate limiting. Infrastructure changes include new Docker deployment configurations and a consolidated initial database migration. Review feedback identifies a potential race condition in the user repository following the removal of atomic upsert logic, an inconsistency in rate-limiting error formats, and a layering violation where the service layer directly references API DTOs.
📚작업 내용
private set으로 수정STEAM_APP_ID)로 외부 주입하도록 변경Steam AppId는 기존 하드코딩(480)에서 환경변수로 변경되었습니다. 배포 시
STEAM_APP_ID시크릿이 GitHub Actions에 등록되어 있어야 합니다.✅체크리스트