Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the production deployment configuration by removing the local PostgreSQL database service, renaming existing services for consistency, and introducing a dedicated Docker network. It also clears hardcoded connection strings and API keys from the application settings. Feedback includes a critical observation regarding a missing environment variable for the external database connection string in the Docker Compose file, which would cause a runtime exception, and a suggestion to align the server's container name with its new service name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚작업 내용
DB는 compose에서 분리하여 외부 PostgreSQL 인스턴스를 사용합니다. Redis는 compose 내부 서비스로 운영하며, pushandpull-network 브릿지 네트워크로 연결됩니다. 시크릿(DB_CONNECTION_STRING, REDIS_CONNECTION_STRING, STEAM_WEB_API_KEY)은 GitHub Secrets에서 SSH 배포 시 .env 파일로 주입됩니다.
✅체크리스트