Skip to content

User/nathan/feature/teampictures#22

Open
nathana10988 wants to merge 24 commits intodevelopfrom
user/nathan/feature/teampictures
Open

User/nathan/feature/teampictures#22
nathana10988 wants to merge 24 commits intodevelopfrom
user/nathan/feature/teampictures

Conversation

@nathana10988
Copy link
Contributor

We need to wait for everyone to give a bio

@nathana10988
Copy link
Contributor Author

should be ready to merge

@nathana10988 nathana10988 requested a review from Nsl106 October 28, 2023 14:01
@Nsl106
Copy link
Member

Nsl106 commented Oct 29, 2023

image
On my computer (firefox) it shows the footer above the bottom of the page

image
Also, the squares seem to overlap the text when you click on bios

It looks awesome though, you've made a lot of good progress!

@Nsl106
Copy link
Member

Nsl106 commented Oct 30, 2023

oh also, do you want to move the svg part of the bios to a separate file so you can just import it as an image instead of having the whole thing in each bio?

@nathana10988
Copy link
Contributor Author

oh also, do you want to move the svg part of the bios to a separate file so you can just import it as an image instead of having the whole thing in each bio?

what folder should i put the file in?

@Nsl106
Copy link
Member

Nsl106 commented Oct 30, 2023

Icons maybe? Or you could make a separate one called 'squares' or whatever you want you want to call them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants