Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 99.29% 99.00% -0.30%
==========================================
Files 43 43
Lines 1981 2003 +22
==========================================
+ Hits 1967 1983 +16
- Misses 7 10 +3
- Partials 7 10 +3
Continue to review full report at Codecov.
|
TcM1911
requested changes
May 14, 2022
| return obj | ||
| } | ||
|
|
||
| func FromReader(reader io.Reader, opts ...CollectionOption) (*Collection, error) { |
Owner
There was a problem hiding this comment.
Please add documentation to this function since it's exported.
| collection := New(opts...) | ||
| buff := bufio.NewReader(reader) | ||
| piece, err := buff.Peek(10) | ||
| if err != nil && !(err == io.EOF || err == bufio.ErrBufferFull) { |
Owner
There was a problem hiding this comment.
Can you add tests for this since it's checking for specific error cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability for a user to generate a collection directly from a reader