This repository was archived by the owner on Dec 4, 2021. It is now read-only.
Open
Conversation
the occasional silence for stage music happens automatically, and always occurs in the first room of a new run
add silent sound files to override existing Devil Room Appear and Angel Room Appear jingles
add new sound files for Devil Room Appear and Angel Room Appear that we will play at the appropriate times when not overwritten by a music callback
tweak music jingle boss room code to be more accurate to vanilla behavior (do not continue boss over music from angel fight from angel room into the boss room)
Soul of the Forgotten (the temporary helper skeleton) was triggering the choir sound upon collision with an item pedestal
fixed rare issue where music jingle's next track played during unlock/achievement page animations between floors
this was an absolute pain in the ass and there might be more bugs, but I did a lot of testing to weed out edge cases, so it should emulate vanilla gameplay very closely
-don't play choir noise for Tainted Cain transforming collectibles into pickups upon contact -handle card and rune use cases -decrease choir sound effect volume to closer match vanilla
remove complicated solution and replace with simple one
-don't crossfade into Boss Over Twisted -play Hush boss music when big Hush spawns, not when Hush Baby leaves -determine alt boss music based on the intended room flag -play Boss Over Twisted throughout all of Mausoleum/Gehenna after killing Mom's Heart -don't consider minecart switches found in Red Rooms
use Gridroom enums for Rotgut and Beast dungeons
use MUSIC_JINGLE_MOTHER_OVER
prevents boss defeated music playing while fighting ultra greedier
fix dev stupidity introduced by Rep Plus code written by Nato Potato
-fixed dreamcatcher floor music start check not working for soundtracks with a custom nightmare track -fixed dogma intro and music sometimes not playing for soundtracks with a custom dogma nightmare track
Code written by Nato Potato
also improve death certificate backdrop comparison code
stops buggy music happening when using the epiphany mod and starting a run as one of the bonus characters
first room in death certificate floor uses a different backdrop type from the rest, so the flag was being set to true on item use and then immediately set back to false since the room didn't match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.