Add option to write crash dump on unhandled exception on Windows#122
Add option to write crash dump on unhandled exception on Windows#122hardliner66 wants to merge 1 commit intoTaterClient:masterfrom
Conversation
|
I feel like this should be upstreamed |
|
@SollyBunny probably, but because this is a fork of ddnet, github doesn't let me create a fork of this repo and of ddnet at the same time, making it a bit of a pain to work with both. I mostly added it to help with #57, but I might try adding it upstream as well. For upstream I think it would be nice to have something that works on linux too (e.g.: crashpad or something similar), but for that I would need to take more time to look into the whole topic. |
|
"Forks" are only a github thing, git lets you have as many upstreams as you want git remote add tater https://github.com/sjrc6/TaterClient-ddnet
git fetch tater
git checkout tater/master
git switch -c tater_feature
git push origin HEAD:tater_feature
git checkout my_ddnet_feature
git pull ddnet master
git push origin |
|
Chillerdragon has been pushing for easy crash dumps for post mortem debugging, I don't know what that looks like in the head of the maintainers, but make a pr and see it would probably spark some discussion atleast |
|
Yeah, I know that git itself can deal with this, but given the limited implementation I didn't think it was worth the effort. For upstream it might even make sense to use something more sophisticated (automatic upload, crash Dialog with button to open a new git issue, etc.). But you're right, having a starting point to spark a discussion would definitely be a good thing. And in the end, having something simple like this might still be better than having nothing at all. I'll create a PR for upstream later when I'm back on PC. |
f6a5385 to
fdde946
Compare
85e99b8 to
8716ec3
Compare
39265a2 to
0796368
Compare
1e549e3 to
0c27c3e
Compare
d306b83 to
689e1d8
Compare
9243aac to
8e5d87a
Compare
While thinking about #57, I remembered that its possible to write
*.dmpwhen an unhandled exception occurs. This adds a setting for windows users, that controls if a dump is written or not.If the exe was built with debug infos (
RelWithDebInfo), the dump can be loaded together with the corresponding*.pdbfile in WinDbg, which can then be used to further analyze the dump.Checklist