Skip to content

Quest Definition Schema Version 3.0.0 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uw-amy-bordenave merged 11 commits into from
Sep 24, 2025
Merged

Quest Definition Schema Version 3.0.0 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1d6a08e
Add multiple dependency quest definition example
uw-amy-bordenave Jul 30, 2025
8afa54c
Upgrade to schema 3.0.0 with support for multiple dependencies
uw-amy-bordenave Jul 30, 2025
e93ebe3
Add conditional requirement for quest_answer_choices based on quest_t…
iamrajeshk Sep 16, 2025
425975b
Merge branch 'main' into quest-definition-schema-3.0.0
uw-amy-bordenave Sep 16, 2025
ddccf79
Auto-generate image READMEs
github-actions[bot] Sep 16, 2025
2f7a95e
Merge branch 'main' into quest-definition-schema-3.0.0
uw-amy-bordenave Sep 23, 2025
2a83840
Fix `quest_answer_choices` requirement logic
uw-amy-bordenave Sep 23, 2025
af89ce2
Replace "GoInfoGame" with "AVIV ScoutRoute"
uw-amy-bordenave Sep 23, 2025
3865c8d
Add missing `required` fields to `dependency` section
uw-amy-bordenave Sep 23, 2025
2991e93
Update `quest_answer_choices` description
uw-amy-bordenave Sep 23, 2025
fe51a3c
Update `question_id` examples
uw-amy-bordenave Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 59 additions & 9 deletions docs/quest-definition/example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "2.0.0",
"version": "3.0.0",
"elements": [
{
"element_type": "Sidewalks",
Expand Down Expand Up @@ -187,6 +187,53 @@
"choice_text": "No"
}
]
},
{
"quest_id": 10,
"quest_title": "What amenities are available along this sidewalk?",
"quest_description": "Select all amenities that are present along this sidewalk",
"quest_type": "MultipleChoice",
"quest_tag": "amenity",
"quest_answer_choices": [
{
"value": "benches",
"choice_text": "Benches",
"image_url": "http://some_url.com/image.jpg"
},
{
"value": "trash_bins",
"choice_text": "Trash bins",
"image_url": "http://some_url.com/image.jpg"
},
{
"value": "water_fountains",
"choice_text": "Water fountains",
"image_url": "http://some_url.com/image.jpg"
},
{
"value": "bike_racks",
"choice_text": "Bike racks",
"image_url": "http://some_url.com/image.jpg"
},
{
"value": "shade_structures",
"choice_text": "Shade structures",
"image_url": "http://some_url.com/image.jpg"
},
{
"value": "public_art",
"choice_text": "Public art",
"image_url": "http://some_url.com/image.jpg"
}
]
},
{
"quest_id": 11,
"quest_title": "Are there any other notable features or issues with this sidewalk?",
"quest_description": "Please describe any other notable features or issues with this sidewalk that were not covered in the previous questions.",
"quest_image_url": "http://some_url.com/image.jpg",
"quest_type": "TextEntry",
"quest_tag": "sidewalk_notes"
}
]
},
Expand Down Expand Up @@ -319,10 +366,7 @@
],
"quest_answer_dependency": {
"question_id": 4,
"required_value": [
"1",
"2"
]
"required_value": ["1", "2"]
Copy link

@cyrossignol cyrossignol Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you get more into GitHub, here's a friendly PR etiquette tip: I'd avoid mixing cosmetic and content changes in the same PR. The noisy diffs may divert attention from the "meat" of the PR. Good PRs usually have a narrow focus/scope.

In this case, I'm also a little worried that someone may inadvertently reverse the changes with some automated formatting tool—some editors run these automatically these days.

Copy link
Collaborator Author

@uw-amy-bordenave uw-amy-bordenave Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up and the best-practices tip :)
In this case, that's exactly what happened - ran the Prettier formatter in VS Code.

Copy link

@cyrossignol cyrossignol Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to check in that Prettier config to this repo so tools don't fight with each other over formatting.

}
},
{
Expand Down Expand Up @@ -491,10 +535,16 @@
"image_url": "http://some_url.com/image.jpg"
}
],
"quest_answer_dependency": {
"question_id": 4,
"required_value": "yes"
}
"quest_answer_dependency": [
{
"question_id": 4,
"required_value": "yes"
},
{
"question_id": 5,
"required_value": "yes"
}
]
},
{
"quest_id": 7,
Expand Down
Loading