This repository was archived by the owner on Oct 2, 2025. It is now read-only.
add favicon #14
Merged
add favicon #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a favicon and tidies up HTML, CSS, and script formatting for Layout.astro.
- Introduce a
<link rel="icon">tag pointing to an external favicon - Reformat meta tags, font-link tags, CSS custom properties, and inline scripts for consistent multi-line styling
- Standardize quote usage across imports, HTML attributes, and JS
Comments suppressed due to low confidence (1)
src/layouts/Layout.astro:33
- [nitpick] The CSS block indentation is deeper than the surrounding rules, leading to mixed indent styles. Align with the project’s standard indent (e.g., 2 or 4 spaces) for easier maintenance.
--font-sans:
| href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;700&display=swap" | ||
| rel="stylesheet" | ||
| /> | ||
| <link rel="icon" href="https://fav.farm/🔧" /> |
There was a problem hiding this comment.
[nitpick] Linking to an external favicon service can introduce latency or availability risks. Consider hosting the favicon locally or bundling it with the build for more reliable delivery.
Suggested change
| <link rel="icon" href="https://fav.farm/🔧" /> | |
| <link rel="icon" href="/favicon.ico" /> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.