Add SANDBOX_USE_SRT and ENABLE_SEMANTIC_SEARCH environment variables#4
Add SANDBOX_USE_SRT and ENABLE_SEMANTIC_SEARCH environment variables#4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 138ed27946
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expert_names=expert_names, | ||
| max_turns=max_turns, | ||
| max_budget_usd=max_budget_usd, | ||
| allowed_tools=allowed_tools, | ||
| ) |
There was a problem hiding this comment.
run_discussion_for_topic() accepts an allowed_tools argument from the API layer, but this call no longer forwards it to run_discussion(), so custom tool allowlists are silently ignored and the default tool set is used instead. This changes runtime behavior for any topic that configures restricted tools (or depends on extra tools) and can unintentionally broaden tool access.
Useful? React with 👍 / 👎.
| if SANDBOX_AVAILABLE: | ||
| sandbox_type = "macos-sandbox-exec" if MACOS_SANDBOX else "linux-bwrap" | ||
| logger.info("[SandboxExec] OS sandbox available: %s", sandbox_type) | ||
| SANDBOX_AVAILABLE: bool = SRT_AVAILABLE or MACOS_SANDBOX or LINUX_BWRAP |
There was a problem hiding this comment.
SANDBOX_AVAILABLE is now true whenever srt is installed, but run_in_os_sandbox() can still skip srt when SANDBOX_USE_SRT=false and then fall through to the legacy backend path. On hosts that have srt installed but lack sandbox-exec/bwrap, callers that gate on SANDBOX_AVAILABLE will still invoke sandboxing and hit a missing-backend failure instead of the intended unsandboxed fallback.
Useful? React with 👍 / 👎.
| --with httpx \ | ||
| pytest -m "not integration" -v --tb=short | ||
| pytest -m "not integration" -v --tb=short; then | ||
| UNIT_RC=$? |
There was a problem hiding this comment.
Inside the if ! uv run ...; then block, UNIT_RC=$? records the status of the negated condition (which is 0 in this branch), and the script never exits non-zero for unit-test failures. As a result, scripts/ci_local.sh can report success after passing integration tests even when the unit-test gate failed, which breaks the script’s stated CI-equivalence behavior.
Useful? React with 👍 / 👎.
Add get_sandbox_use_srt() to app/core/config.py. This boolean flag (default: true) controls whether the system prefers sandbox-runtime (srt) over the legacy bwrap/sandbox-exec code path for OS-level sandboxing. Operators can set SANDBOX_USE_SRT=false to fall back. Part of the sandbox-runtime integration work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remote force-push reverted two earlier fixes (commit 202e785). Re-applying them: 1. app/services/profile_helper/sessions.py: re-add list_ids() function that returns all active session IDs after cleanup. Required by agent_links API which imports and calls profile_sessions.list_ids(). 2. tests/test_agent_links_api.py: re-add session_id parameter to _fake_stream_chat() mock. The actual API passes session_id as a keyword argument to stream_chat(). Note: test_copy_mcp_to_workspace_with_env failure is a pre-existing issue from remote (test expects streamableHttp MCP copy, but code intentionally skips it). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ntries Normalize libs metadata JSON formatting and add test sample entries for topiclab_shared experts and moderator_modes. Add .github/copilot-instructions.md for repository-specific Copilot CLI guidance. These changes were created locally during workspace sync and are being committed to keep the repo tidy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…EARCH (env)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Change Type
Description
Add SANDBOX_USE_SRT and ENABLE_SEMANTIC_SEARCH environment variables
Related Issue
none
Checklist
pytest -q -m "not integration".env:bash scripts/ci_local.sh