Merged
Conversation
If there's an error in ipc_sync_done(), we don't want to call it again. Reported by: clang19 scan-build
Reported by: clang19 scan-build
Previously, we combined strings with:
d="$a $b $c"
If $b was "", that would leave two spaces, which we trimmed with
tr -s ' '
However, that was an inelegant solution, and more importantly, was not
compatible with code such as:
-D_TWO_SPACES="\"2 spaces\""
when defined in Makefile.BSD.
Ideally, there would always be 0 errors. However, due to porting issues, some platforms report a non-zero number of errors even for trivial programs.
cpusupport-ARM-AES.c: the info about _u32 was in a git commit message,
but it's worth adding a 1-line comment about it.
cpusupport-X86-SSE42*.c: our STYLE says that we should never use
(unsigned char). That's what the definition of _mm_crc32_u8() uses,
but the code in alg/crc32_sse42.c uses (uint8_t), so there's no
point violating our STYLE by using (unsigned char) here.
network_ssl_compat.c: fix style of assignment & checking.
imalloc.h: split the "return (NULL)" cases from the actual malloc().
A source or destination address of the form ":1234" is parsed as a hostname of "" which is guaranteed to never work. While we don't want to give special error messages for all possible invalid addresses, this particular case can easily be produced from a broken shell script (with a hostname variable accidentally not set), so it's worth having a special error message. Suggested by: Ross Richardson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.