feat: migrate into biome instead of ESLint#2
Conversation
Summary of ChangesHello @TarasKovalenko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request overhauls the project's code quality infrastructure by transitioning from ESLint to Biome. The change aims to simplify the development setup and improve performance by using a unified tool for both linting and code formatting. This involves a comprehensive cleanup of old tooling and the integration of new configurations and commands, resulting in a more consistent and efficient codebase. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The migration from ESLint to Biome is a positive step for the project's performance and developer experience. The pull request successfully removes ESLint configurations and dependencies while updating the codebase to adhere to Biome's formatting and linting standards. However, there are a few critical issues to address: the @biomejs/biome package is missing from devDependencies, and the biome.json configuration contains an incorrect schema version and redundant glob patterns. Addressing these will ensure a stable and maintainable linting setup.
| }, | ||
| "devDependencies": { | ||
| "@eslint/js": "^10.0.1", | ||
| "@types/node": "^25.3.0", |
There was a problem hiding this comment.
The @biomejs/biome package is used in the project's scripts but is not listed in devDependencies. It should be explicitly added to ensure version consistency across different environments and to avoid the overhead of npx downloading the package during every execution.
| "@types/node": "^25.3.0", | |
| "@biomejs/biome": "^1.9.4", | |
| "@types/node": "^25.3.0", |
package.json
Outdated
| "lint": "npx @biomejs/biome lint . --max-diagnostics=200", | ||
| "lint:fix": "npx @biomejs/biome check . --write --unsafe --max-diagnostics=200", | ||
| "format": "npx @biomejs/biome format --write .", |
There was a problem hiding this comment.
Once @biomejs/biome is added to the project's dependencies, you should invoke the biome binary directly in the scripts instead of using npx. This is more efficient and follows standard Node.js project practices.
| "lint": "npx @biomejs/biome lint . --max-diagnostics=200", | |
| "lint:fix": "npx @biomejs/biome check . --write --unsafe --max-diagnostics=200", | |
| "format": "npx @biomejs/biome format --write .", | |
| "lint": "biome lint . --max-diagnostics=200", | |
| "lint:fix": "biome check . --write --unsafe --max-diagnostics=200", | |
| "format": "biome format --write .", |
| @@ -0,0 +1,46 @@ | |||
| { | |||
| "$schema": "https://biomejs.dev/schemas/2.4.3/schema.json", | |||
There was a problem hiding this comment.
The schema version 2.4.3 appears to be incorrect as the current stable version of Biome is 1.9.4. Using an invalid version in the schema URL will prevent IDEs from providing proper configuration validation and autocompletion.
| "$schema": "https://biomejs.dev/schemas/2.4.3/schema.json", | |
| "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json", |
| "files": { | ||
| "includes": [ | ||
| "**", | ||
| "!**/node_modules", | ||
| "!**/dist", | ||
| "!**/coverage", | ||
| "!**/src-tauri/target", | ||
| "!**/.venv-ci", | ||
| "!!**/node_modules", | ||
| "!!**/dist", | ||
| "!!**/coverage", | ||
| "!!**/src-tauri/target", | ||
| "!!**/.venv-ci" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
The files configuration contains redundant patterns (e.g., !!) and uses negated includes for ignoring directories. Biome processes all files by default, so includes: ["**"] is unnecessary. It is recommended to use the dedicated ignore field for excluding directories like node_modules and dist.
"files": {
"ignore": [
"node_modules",
"dist",
"coverage",
"src-tauri/target",
".venv-ci"
]
},
1 participant
No description provided.