Skip to content

feat(react-component): expose element class names#466

Merged
mimshins merged 5 commits intomainfrom
fix/react-components/expose-element-class
May 4, 2025
Merged

feat(react-component): expose element class names#466
mimshins merged 5 commits intomainfrom
fix/react-components/expose-element-class

Conversation

@amir78729
Copy link
Member

fixes #464

@mimshins
Copy link
Collaborator

mimshins commented May 3, 2025

@amir78729
Thanks for the great job!
I was thinking that using the Element postfix, similar to browser conventions like HTMLInputElement, might be more intuitive than ElementClass. What do you think?

@amir78729
Copy link
Member Author

@amir78729
Thanks for the great job!
I was thinking that using the Element postfix, similar to browser conventions like HTMLInputElement, might be more intuitive than ElementClass. What do you think?

You're right. I’d suggest we start by adopting this convention in our web-component package first before rolling it out more broadly across other packages. What do you think?

@mimshins mimshins merged commit 756d70e into main May 4, 2025
8 checks passed
@mimshins mimshins deleted the fix/react-components/expose-element-class branch May 4, 2025 16:05
@github-actions github-actions bot mentioned this pull request May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(react-components): expose elementClass outside of the component

2 participants