Downgrade Gradle plugin to 7.3.1 and wrapper to 7.4#55
Open
mustafaabobakr wants to merge 1 commit intogradle_8.4.0from
Open
Downgrade Gradle plugin to 7.3.1 and wrapper to 7.4#55mustafaabobakr wants to merge 1 commit intogradle_8.4.0from
mustafaabobakr wants to merge 1 commit intogradle_8.4.0from
Conversation
Revert Gradle plugin to 7.3.1 and wrapper to 7.4, and lower compileSdkVersion and targetSdkVersion to 34. Also update goSellSDK-AndroidX and material dependencies, and remove several unused dependencies from build.gradle.
mustafaabobakr
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR downgrades the Android build configuration to use older, more stable versions of Gradle and Android SDK components. The changes revert from newer versions to established ones and clean up unused dependencies.
- Downgrades Gradle wrapper from 8.6 to 7.4 and Android Gradle plugin from 8.4.0 to 7.3.1
- Reduces Android SDK versions from 35 to 34 for both compile and target SDK
- Updates goSellSDK-AndroidX dependency and removes multiple unused dependencies
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| android/gradle/wrapper/gradle-wrapper.properties | Downgrades Gradle wrapper from version 8.6 to 7.4 |
| android/build.gradle | Downgrades Android Gradle plugin, SDK versions, updates goSellSDK dependency, and removes unused dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| implementation 'jp.wasabeef:blurry:4.0.1' | ||
| implementation 'io.card:android-sdk:5.5.1' | ||
| implementation 'com.github.bumptech.glide:glide:4.12.0' | ||
| implementation 'com.google.android.material:material:1.12.0-alpha03' |
There was a problem hiding this comment.
Using an alpha version (1.12.0-alpha03) in production code introduces stability risks. Consider using a stable release version instead, especially when the PR goal is to use more stable versions.
Suggested change
| implementation 'com.google.android.material:material:1.12.0-alpha03' | |
| implementation 'com.google.android.material:material:1.11.0' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert Gradle plugin to 7.3.1 and wrapper to 7.4, and lower compileSdkVersion and targetSdkVersion to 34. Also update goSellSDK-AndroidX and material dependencies, and remove several unused dependencies from build.gradle.