Conversation
…ublic key verification Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Tanker187/firebase-admin-node/security/code-scanning/12
In general, to fix this class of problem you must always pass a real cryptographic secret or public key to
jwt.verify(or an appropriate key-resolving callback), neverundefined,null,false, or an empty string. You should also avoid using thenonealgorithm in verification except in very constrained, non-security-critical scenarios, and then only in ways that don’t encourage insecure patterns.In this test, we do not actually need to verify the token cryptographically; we just want to ensure that calling
jwt.verifydoes not throw when presented with an unsigned token produced bycreateCustomToken()in emulator mode. We can achieve that without disabling integrity checks by avoidingjwt.verifyentirely and instead usingjwt.decode, which does not perform signature verification but suffices to ensure the token is structurally valid and decodable. The test already usesjwt.decodeearlier to check the header and payload. Therefore, the minimal change is to remove the dangerousjwt.verifycall and replace it with a harmless decode (or simply rely on the existing decode) to assert that no exception is thrown. Concretely, intest/unit/auth/auth.spec.ts, in theit('createCustomToken() generates an unsigned token', ...)block, replace line 3899 with a safe operation, such as anotherjwt.decodecall, or simply remove it and, if desired, wrap the original decode in a try/catch-based expectation to show no error is thrown. No new imports or helpers are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.