Adds qr-code for bank payment for my account page #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswfi
requested changes
Dec 1, 2025
Member
tswfi
left a comment
tswfi
left a comment
There was a problem hiding this comment.
The call for generation from template can be simplified (and I would rename it to "generate_epc_qr_code_for_subscriotion" or something like that to make it clear that it only for subscriptions.
Otherwise this looks great 👍
| <td>{% trans 'Payment QR Code' %}</td> | ||
| <td> | ||
| <p class="text-muted">{% trans 'Scan with your banking app to pay' %}</p> | ||
| {% payment_qr_code subscription bank_iban bank_bic bank_name %} |
Member
There was a problem hiding this comment.
Subscription should be enough for this call. Iban, bic and others can be read from settings in the method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #550
What is in this pr:
Add qr-code for bank payment for my account page
Basic test for svg functionality for EPC QR code generation for bank payments