Converted to Swift 3 by zirinisp · Pull Request #11 · Tallwave/Gliphy

zirinisp · 2016-09-21T12:52:29Z

No description provided.

houndci-bot · 2016-09-21T12:52:37Z

Sources/Core/StyleWatcher.swift

-            customFontName = config.textView[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.textView[textStyle],
+            let fontName = customFontName else { return }


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:37Z

Sources/Core/StyleWatcher.swift

-            customFontName = config.textView[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.textView[textStyle],
+            let fontName = customFontName else { return }


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:37Z

Sources/Core/StyleWatcher.swift

        guard let textStyle = textView.textStyle,
-            customFontName = config.textView[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.textView[textStyle],


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:37Z

Sources/Core/StyleWatcher.swift

        guard let textStyle = textView.textStyle,
-            customFontName = config.textView[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.textView[textStyle],


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

-            customFontName = config.textField[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.textField[textStyle],
+            let fontName = customFontName else { return }


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

-            customFontName = config.textField[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.textField[textStyle],
+            let fontName = customFontName else { return }


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

        guard let textStyle = textField.textStyle,
-            customFontName = config.textField[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.textField[textStyle],


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

        guard let textStyle = textField.textStyle,
-            customFontName = config.textField[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.textField[textStyle],


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

-            customFontName = config.label[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.label[textStyle],
+            let fontName = customFontName else { return }


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

-            customFontName = config.label[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.label[textStyle],
+            let fontName = customFontName else { return }


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

        guard let textStyle = label.textStyle,
-            customFontName = config.label[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.label[textStyle],


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

        guard let textStyle = label.textStyle,
-            customFontName = config.label[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.label[textStyle],


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

-            customFontName = config.button[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.button[textStyle],
+            let fontName = customFontName else { return }


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

-            customFontName = config.button[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.button[textStyle],
+            let fontName = customFontName else { return }


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

        guard let textStyle = button.textStyle,
-            customFontName = config.button[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.button[textStyle],


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/StyleWatcher.swift

        guard let textStyle = button.textStyle,
-            customFontName = config.button[textStyle],
-            fontName = customFontName else { return }
+            let customFontName = config.button[textStyle],


Conditional Binding Cascade Violation: Repeated let statements in conditional binding cascade should be avoided. (conditional_binding_cascade)

houndci-bot · 2016-09-21T12:52:38Z

Sources/Core/Extensions.swift

-    var textStyle: String? {
-        return font?.fontDescriptor().fontAttributes()[Util.dynamicTextAttribute] as? String
+    var textStyle: UIFontTextStyle? {
+        guard let fontTextStyleString = font?.fontDescriptor.fontAttributes[Util.dynamicTextAttribute] as? String else {


Line Length Violation: Line should be 100 characters or less: currently 120 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/Extensions.swift

-    var textStyle: String? {
-        return font?.fontDescriptor().fontAttributes()[Util.dynamicTextAttribute] as? String
+    var textStyle: UIFontTextStyle? {
+        guard let fontTextStyleString = font?.fontDescriptor.fontAttributes[Util.dynamicTextAttribute] as? String else {


Line Length Violation: Line should be 100 characters or less: currently 120 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/Extensions.swift

-    var textStyle: String? {
-        return font?.fontDescriptor().fontAttributes()[Util.dynamicTextAttribute] as? String
+    var textStyle: UIFontTextStyle? {
+        guard let fontTextStyleString = font?.fontDescriptor.fontAttributes[Util.dynamicTextAttribute] as? String else {


Line Length Violation: Line should be 100 characters or less: currently 120 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/Extensions.swift

-    var textStyle: String? {
-        return font?.fontDescriptor().fontAttributes()[Util.dynamicTextAttribute] as? String
+    var textStyle: UIFontTextStyle? {
+        guard let fontTextStyleString = font?.fontDescriptor.fontAttributes[Util.dynamicTextAttribute] as? String else {


Line Length Violation: Line should be 100 characters or less: currently 120 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/Extensions.swift

-        let key = Util.dynamicTextAttribute
-        return titleLabel?.font.fontDescriptor().fontAttributes()[key] as? String
+    var textStyle: UIFontTextStyle? {
+        guard let fontTextStyleString = titleLabel?.font?.fontDescriptor.fontAttributes[Util.dynamicTextAttribute] as? String else {


Line Length Violation: Line should be 100 characters or less: currently 132 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/Extensions.swift

-        let key = Util.dynamicTextAttribute
-        return titleLabel?.font.fontDescriptor().fontAttributes()[key] as? String
+    var textStyle: UIFontTextStyle? {
+        guard let fontTextStyleString = titleLabel?.font?.fontDescriptor.fontAttributes[Util.dynamicTextAttribute] as? String else {


Line Length Violation: Line should be 100 characters or less: currently 132 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/Extensions.swift

-    var textStyle: String? {
-        return font.fontDescriptor().fontAttributes()[Util.dynamicTextAttribute] as? String
+    var textStyle: UIFontTextStyle? {
+        guard let fontTextStyleString = font?.fontDescriptor.fontAttributes[Util.dynamicTextAttribute] as? String else {


Line Length Violation: Line should be 100 characters or less: currently 120 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/Extensions.swift

-    var textStyle: String? {
-        return font.fontDescriptor().fontAttributes()[Util.dynamicTextAttribute] as? String
+    var textStyle: UIFontTextStyle? {
+        guard let fontTextStyleString = font?.fontDescriptor.fontAttributes[Util.dynamicTextAttribute] as? String else {


Line Length Violation: Line should be 100 characters or less: currently 120 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/DynamicTypeManager.swift

     - Parameter fontName: The name of the custom font to use.
     */
-    public func watchElement(view: UIView, fontKeyPath: String, textStyle: String, fontName: String) {
+    open func watchElement(_ view: UIView, fontKeyPath: String, textStyle: UIFontTextStyle, fontName: String) {


Line Length Violation: Line should be 100 characters or less: currently 111 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/DynamicTypeManager.swift

     - Parameter fontName: The name of the custom font to use.
     */
-    public func watchElement(view: UIView, fontKeyPath: String, textStyle: String, fontName: String) {
+    open func watchElement(_ view: UIView, fontKeyPath: String, textStyle: UIFontTextStyle, fontName: String) {


Line Length Violation: Line should be 100 characters or less: currently 111 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/DynamicTypeManager.swift

     - Parameter fontName: The name of the custom font to use.
     */
-    public func watchTextField(textField: UITextField, textStyle: String, fontName: String) {
+    open func watchTextField(_ textField: UITextField, textStyle: UIFontTextStyle, fontName: String) {


Line Length Violation: Line should be 100 characters or less: currently 102 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/DynamicTypeManager.swift

     - Parameter fontName: The name of the custom font to use.
     */
-    public func watchTextField(textField: UITextField, textStyle: String, fontName: String) {
+    open func watchTextField(_ textField: UITextField, textStyle: UIFontTextStyle, fontName: String) {


Line Length Violation: Line should be 100 characters or less: currently 102 characters (line_length)

houndci-bot · 2016-09-21T12:52:39Z

Sources/Core/DynamicTypeManager.swift


    /// Storage and lookup for the views `DynamicTypeManager` is tracking.
-    private var elementToTypeTable: NSMapTable = NSMapTable.weakToStrongObjectsMapTable()
+    fileprivate var elementToTypeTable: NSMapTable<AnyObject, AnyObject> = NSMapTable.weakToStrongObjects()


Line Length Violation: Line should be 100 characters or less: currently 107 characters (line_length)

houndci-bot · 2016-09-21T12:52:40Z

Sources/Core/DynamicTypeManager.swift


    /// Storage and lookup for the views `DynamicTypeManager` is tracking.
-    private var elementToTypeTable: NSMapTable = NSMapTable.weakToStrongObjectsMapTable()
+    fileprivate var elementToTypeTable: NSMapTable<AnyObject, AnyObject> = NSMapTable.weakToStrongObjects()


Line Length Violation: Line should be 100 characters or less: currently 107 characters (line_length)

houndci-bot · 2016-09-21T12:52:40Z

Sources/Core/DynamicFontRegistry.swift

     - Parameter textStyle: The identifier to look up.
    */
-    func scaledFontSizeForStyle(textStyle: String) -> CGFloat? {
+    func scaledFontSizeForStyle(_ textStyle: UIFontTextStyle) -> CGFloat? {


Valid Docs Violation: Documented declarations should be valid. (valid_docs)

houndci-bot · 2016-09-21T12:52:40Z

Sources/Core/DynamicFontRegistry.swift

     - Parameter textStyle: The identifier to look up.
    */
-    func scaledFontSizeForStyle(textStyle: String) -> CGFloat? {
+    func scaledFontSizeForStyle(_ textStyle: UIFontTextStyle) -> CGFloat? {


Valid Docs Violation: Documented declarations should be valid. (valid_docs)

swilliams · 2016-09-23T16:13:33Z

Thanks for the PR! I want to be real intentional about implementing Swift 3, and I'm not sure if everything here is how to go about it. I also don't have a ton of time to devote to it, but fully intend to.

(Not so concerned about Hound or Travis errors either, they're way too finicky right now)

jmbeneUF · 2017-02-06T20:00:48Z

Any news about this?

Converted to Swift 3

9ed95b4

houndci-bot reviewed Sep 21, 2016

View reviewed changes

Conversation

zirinisp commented Sep 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swilliams commented Sep 23, 2016

Uh oh!

jmbeneUF commented Feb 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants