Skip to content

debug for flaky test #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TakaHiR07 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

debug for flaky test #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .../src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,7 @@ public void addOwnedNamespaceBundleAsync(NamespaceBundle namespaceBundle) {

@VisibleForTesting
@NonNull CompletableFuture<Boolean> prepareInitPoliciesCacheAsync(@NonNull NamespaceName namespace) {
log.info("enter prepareInitPoliciesCacheAsync. ns:{}. this:{}", namespace, this);
requireNonNull(namespace);
if (closed.get()) {
return CompletableFuture.completedFuture(false);
Expand Down Expand Up @@ -825,6 +826,8 @@ private void readMorePoliciesAsync(SystemTopicClient.Reader<PulsarEvent> reader)
}
reader.readNextAsync()
.thenAccept(msg -> {
log.info("finish readMorePoliciesAsync 1. ns:{}, this:{}, reader:{}",
namespaceObject.toString(), this, reader);
try {
refreshTopicPoliciesCache(msg);
try {
Expand All @@ -838,6 +841,8 @@ private void readMorePoliciesAsync(SystemTopicClient.Reader<PulsarEvent> reader)
}
})
.whenComplete((__, ex) -> {
log.info("finish readMorePoliciesAsync 2. ns:{}, this:{}, reader:{}, ex:{}",
namespaceObject.toString(), this, reader, ex);
if (ex == null) {
readMorePoliciesAsync(reader);
} else {
Expand Down
11 changes: 10 additions & 1 deletion .../test/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,8 +492,10 @@ public void append(LogEvent event) {
logger.addAppender(appender);

// create namespace-5 and topic
log.info("origin SystemTopicBasedTopicPoliciesService:{}", pulsar.getTopicPoliciesService());
SystemTopicBasedTopicPoliciesService spyService =
Mockito.spy(new SystemTopicBasedTopicPoliciesService(pulsar));
log.info("spy SystemTopicBasedTopicPoliciesService:{}", spyService);
FieldUtils.writeField(pulsar, "topicPoliciesService", spyService, true);


Expand All @@ -515,17 +517,22 @@ public void append(LogEvent event) {
FieldUtils.writeDeclaredField(spyService, "readerCaches", spyReaderCaches, true);

// set topic policy. create producer for __change_event topic
log.info("start setMaxConsumersPerSubscription");
admin.topicPolicies().setMaxConsumersPerSubscription(topic, 1);
log.info("finish setMaxConsumersPerSubscription");
future = spyService.getPoliciesCacheInit(NamespaceName.get(NAMESPACE5));
Assert.assertNotNull(future);
assertTrue(future.isDone());

// trigger close reader of __change_event directly, simulate that reader
// is closed for some reason, such as topic unload or broker restart.
// since prepareInitPoliciesCacheAsync() has been executed, it would go into readMorePoliciesAsync(),
// throw exception, output "Closing the topic policies reader for" and do cleanPoliciesCacheInitMap()
log.info("start close spy reader");
SystemTopicClient.Reader<PulsarEvent> reader = readerCompletableFuture.get();
reader.close();
log.info("successfully close spy reader");

Awaitility.await().untilAsserted(() -> {
boolean logFound = logMessages.stream()
.anyMatch(msg -> msg.contains("Closing the topic policies reader for"));
Expand Down Expand Up @@ -598,9 +605,11 @@ public void append(LogEvent event) {
logger.addAppender(appender);

// create namespace-5 and topic
log.info("origin SystemTopicBasedTopicPoliciesService:{}", pulsar.getTopicPoliciesService());
pulsar.getTopicPoliciesService().close();
SystemTopicBasedTopicPoliciesService spyService =
Mockito.spy(new SystemTopicBasedTopicPoliciesService(pulsar));
FieldUtils.writeField(pulsar, "topicPoliciesService", spyService, true);
log.info("spy SystemTopicBasedTopicPoliciesService:{}", spyService);


admin.namespaces().createNamespace(NAMESPACE5);
Expand Down
Loading