Skip to content

Conversation

@KenVanHoeylandt
Copy link
Contributor

@KenVanHoeylandt KenVanHoeylandt commented Jan 24, 2026

Replace LGPL from past commit with Apache License 2.0 for the newly created projects:

  • in Platforms/*
  • TactilityKernel

Add license headers to source code in:

  • in Platforms/*
  • TactilityKernel
  • TactilityFreeRtos

Updated LICENSE.md

Summary by CodeRabbit

  • Chores

    • Updated licensing: added Apache-2.0 license documents and SPDX identifiers across many files; removed LGPL-3.0 license documents and adjusted top-level licensing guidance and wording
    • Standardized license naming and reformatted license tables and notices
  • Tests

    • Added unit tests for Mutex and RecursiveMutex covering construction, lock state, try-lock/re-entrant behavior, and multi-task blocking scenarios

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 24, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PR removes multiple LGPL-3.0 license files and adds Apache-2.0 license documents. LICENSE.md is revised to list updated license assignments and guidance. SPDX license identifiers (Apache-2.0) are added to many header and source files across Platforms, TactilityFreeRtos, and TactilityKernel. Two new unit test files are added: Tests/TactilityKernel/MutexTest.cpp and Tests/TactilityKernel/RecursiveMutexTest.cpp, exercising mutex and recursive-mutex behaviors including construction, locking, try-lock, and cross-task blocking.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: adding tests (MutexTest.cpp, RecursiveMutexTest.cpp) and updating licenses (adding Apache 2.0 headers, removing LGPL files, updating LICENSE.md).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
Documentation/ideas.md (1)

5-5: Clarify SPDX TODO to match the updated licensing plan.

The TODO references both GPL-3.0-only and Apache-2.0. If GPL is no longer intended for code files after this update, consider rewording to avoid accidental mislabeling.

✏️ Suggested wording
-- Add `// SPDX-License-Identifier: GPL-3.0-only` and `// SPDX-License-Identifier: Apache-2.0` to individual files in the project
+- Add appropriate SPDX-License-Identifier headers per module license (e.g., Apache-2.0 for Platforms/* and TactilityKernel)

@KenVanHoeylandt KenVanHoeylandt merged commit 96eccbd into main Jan 24, 2026
0 of 13 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the tests-and-licenses branch January 24, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants