[WIP] Add playground pages for Successfulness types #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You have some old commits of mine here. I would cherry pick your changes over the latest one to make sure you only have your commits listed in this PR. |
DiceKit.xcodeproj/project.pbxproj
Outdated
| attributes = { | ||
| LastSwiftUpdateCheck = 0700; | ||
| LastUpgradeCheck = 0700; | ||
| LastUpgradeCheck = 0720; |
Member
There was a problem hiding this comment.
Rebasing/cherry picking should remove the need for this.
`Successfulness` can represent the actual number of successes and failures that occurred while evaluating an `ExpressionType`, or it can represent the possibility of successes and failures in the context of a `FrequencyDistribution`.
A paired `FrequencyDistributionOutcomeType` and `Successfulness` Useful for determining the successfulness of expressions.
brentleyjones
force-pushed
the
task/Successfulness
branch
from
57675fa to
a067c24
Compare
JonathanHoffman
force-pushed
the
task/SuccessfulnessPlayground
branch
from
f259192 to
7fdffdf
Compare
brentleyjones
force-pushed
the
task/Successfulness
branch
from
a067c24 to
4fab3dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request supports #119.
Brentley is working on implementing successfulness types, and asked me to help write playground pages for them!
Features
SuccessfulnessOutcomeWithSuccessfulnessMentions
@brentleyjones