perf: cache selectedTabIndex + @ObservationIgnored on internal caches#529
Merged
perf: cache selectedTabIndex + @ObservationIgnored on internal caches#529
Conversation
…d to internal caches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectedTabIndexandselectedTabwere O(n) computed properties scanning thetabsarray viafirst { }. Called 160+ times per body evaluation cycle across 24 files (binding setters, coordinator extensions, view bodies). With 20+ tabs, this accumulated into measurable lag during column resize and sort.[UUID: Int]dictionary lookup, rebuilt only when thetabsarray mutates viadidSet. Amortizes the scan to once per mutation instead of once per access.querySortCacheandisSwitchingDatabaseas@ObservationIgnoredonMainContentCoordinator— both are internal state never read from views, but were broadcasting change notifications on every write.Test plan