fix: address all 6 PR review issues for self-describing plugin system

Author: datlechin

TablePro/AppDelegate+ConnectionHandler.swift

@@ -141,7 +141,7 @@ extension AppDelegate {
         let connectionName = url.deletingPathExtension().lastPathComponent
 
         for (sessionId, session) in DatabaseManager.shared.activeSessions {
-            if session.connection.type == DatabaseType(rawValue: "DuckDB")
+            if session.connection.type == .duckdb
                 && session.connection.database == filePath
                 && session.driver != nil {
                 bringConnectionWindowToFront(sessionId)
@@ -155,7 +155,7 @@ extension AppDelegate {
             port: 0,
             database: filePath,
             username: "",
-            type: DatabaseType(rawValue: "DuckDB")
+            type: .duckdb
         )
 
         openNewConnectionWindow(for: connection)

TablePro/AppDelegate+FileOpen.swift

@@ -66,7 +66,7 @@ extension AppDelegate {
                     switch dbType {
                     case .sqlite:
                         self.handleSQLiteFile(url)
-                    case DatabaseType(rawValue: "DuckDB"):
+                    case .duckdb:
                         self.handleDuckDBFile(url)
                     default:
                         self.handleGenericDatabaseFile(url, type: dbType)

TablePro/Core/Database/DatabaseDriver.swift

@@ -362,15 +362,15 @@ enum DatabaseDriverFactory {
         }
 
         switch connection.type {
-        case DatabaseType(rawValue: "MongoDB"):
+        case .mongodb:
             fields["sslCACertPath"] = ssl.caCertificatePath
             fields["mongoReadPreference"] = connection.mongoReadPreference ?? ""
             fields["mongoWriteConcern"] = connection.mongoWriteConcern ?? ""
-        case DatabaseType(rawValue: "Redis"):
+        case .redis:
             fields["redisDatabase"] = String(connection.redisDatabase ?? 0)
-        case DatabaseType(rawValue: "SQL Server"):
+        case .mssql:
             fields["mssqlSchema"] = connection.mssqlSchema ?? "dbo"
-        case DatabaseType(rawValue: "Oracle"):
+        case .oracle:
             fields["oracleServiceName"] = connection.oracleServiceName ?? ""
         default:
             break

TablePro/Core/Database/DatabaseManager.swift

@@ -803,7 +803,7 @@ final class DatabaseManager {
         driver: DatabaseDriver
     ) async -> String? {
         // Only needed for PostgreSQL PK modifications
-        guard databaseType == .postgresql || databaseType == .redshift || databaseType == DatabaseType(rawValue: "DuckDB") else { return nil }
+        guard databaseType == .postgresql || databaseType == .redshift || databaseType == .duckdb else { return nil }
         guard
             changes.contains(where: {
                 if case .modifyPrimaryKey = $0 { return true }

TablePro/Core/Plugins/PluginManager.swift

@@ -258,14 +258,11 @@ final class PluginManager {
                     driverPlugins[additionalId] = driver
                 }
 
-                // Self-register plugin metadata from the DriverPlugin protocol
-                let driverInstance = driver.createDriver(config: DriverConnectionConfig(
-                    host: "", port: 0, username: "", password: "", database: ""
-                ))
+                // Self-register plugin metadata from the DriverPlugin protocol.
+                // parameterStyle defaults to .questionMark; built-in defaults already have correct values.
                 let snapshot = PluginMetadataRegistry.shared.buildMetadataSnapshot(
                     from: driverType,
-                    isDownloadable: driverType.isDownloadable,
-                    parameterStyle: driverInstance.parameterStyle
+                    isDownloadable: driverType.isDownloadable
                 )
                 PluginMetadataRegistry.shared.register(snapshot: snapshot, forTypeId: typeId)
                 for additionalId in driverType.additionalDatabaseTypeIds {

TablePro/Core/Plugins/PluginMetadataRegistry.swift

@@ -13,7 +13,7 @@ struct ConnectionURLFormatter {
             return formatSQLite(connection.database)
         }
 
-        if connection.type == DatabaseType(rawValue: "DuckDB") {
+        if connection.type == .duckdb {
             return formatDuckDB(connection.database)
         }
 
@@ -76,7 +76,7 @@ struct ConnectionURLFormatter {
             result += ":\(connection.port)"
         }
 
-        let sshPathComponent = connection.type == DatabaseType(rawValue: "Oracle")
+        let sshPathComponent = connection.type == .oracle
             ? (connection.oracleServiceName ?? connection.database)
             : connection.database
         result += "/\(sshPathComponent)"
@@ -109,7 +109,7 @@ struct ConnectionURLFormatter {
             result += ":\(connection.port)"
         }
 
-        let pathComponent = connection.type == DatabaseType(rawValue: "Oracle")
+        let pathComponent = connection.type == .oracle
             ? (connection.oracleServiceName ?? connection.database)
             : connection.database
         result += "/\(pathComponent)"

TablePro/Core/Utilities/Connection/ConnectionURLFormatter.swift

@@ -101,19 +101,19 @@ struct ConnectionURLParser {
         case "sqlite":
             dbType = .sqlite
         case "mongodb", "mongodb+srv":
-            dbType = DatabaseType(rawValue: "MongoDB")
+            dbType = .mongodb
         case "redis", "rediss":
-            dbType = DatabaseType(rawValue: "Redis")
+            dbType = .redis
         case "sqlserver", "mssql", "jdbc:sqlserver":
-            dbType = DatabaseType(rawValue: "SQL Server")
+            dbType = .mssql
         case "oracle", "jdbc:oracle:thin":
-            dbType = DatabaseType(rawValue: "Oracle")
+            dbType = .oracle
         case "clickhouse", "ch":
-            dbType = DatabaseType(rawValue: "ClickHouse")
+            dbType = .clickhouse
         case "cassandra", "cql":
-            dbType = DatabaseType(rawValue: "Cassandra")
+            dbType = .cassandra
         case "scylladb", "scylla":
-            dbType = DatabaseType(rawValue: "ScyllaDB")
+            dbType = .scylladb
         default:
             if let resolvedType = PluginMetadataRegistry.shared.databaseType(forUrlScheme: scheme) {
                 dbType = resolvedType
@@ -186,7 +186,7 @@ struct ConnectionURLParser {
         var sslMode = ext.sslMode
         // Redis-specific: parse database index from path and handle TLS scheme
         var redisDatabase: Int?
-        if dbType == DatabaseType(rawValue: "Redis") {
+        if dbType == .redis {
             if !database.isEmpty {
                 redisDatabase = Int(database)
                 database = ""
@@ -198,7 +198,7 @@ struct ConnectionURLParser {
 
         // Oracle-specific: path component is the service name, not the database name
         var oracleServiceName: String?
-        if dbType == DatabaseType(rawValue: "Oracle") && !database.isEmpty {
+        if dbType == .oracle && !database.isEmpty {
             oracleServiceName = database
             database = ""
         }
@@ -329,7 +329,7 @@ struct ConnectionURLParser {
 
         // Oracle-specific: path component is the service name, not the database name
         var oracleServiceName: String?
-        if dbType == DatabaseType(rawValue: "Oracle") && !database.isEmpty {
+        if dbType == .oracle && !database.isEmpty {
             oracleServiceName = database
             database = ""
         }

TablePro/Core/Utilities/Connection/ConnectionURLParser.swift

@@ -225,6 +225,17 @@ extension DatabaseType {
     static let postgresql = DatabaseType(rawValue: "PostgreSQL")
     static let sqlite = DatabaseType(rawValue: "SQLite")
     static let redshift = DatabaseType(rawValue: "Redshift")
+
+    // Registry-distributed types (known plugins, downloadable separately)
+    static let mongodb = DatabaseType(rawValue: "MongoDB")
+    static let redis = DatabaseType(rawValue: "Redis")
+    static let mssql = DatabaseType(rawValue: "SQL Server")
+    static let oracle = DatabaseType(rawValue: "Oracle")
+    static let clickhouse = DatabaseType(rawValue: "ClickHouse")
+    static let duckdb = DatabaseType(rawValue: "DuckDB")
+    static let cassandra = DatabaseType(rawValue: "Cassandra")
+    static let scylladb = DatabaseType(rawValue: "ScyllaDB")
+    static let etcd = DatabaseType(rawValue: "etcd")
 }
 
 extension DatabaseType: Codable {

TablePro/Models/Connection/DatabaseConnection.swift

@@ -87,7 +87,7 @@ internal final class QuickSwitcherViewModel {
             }
 
             // Schemas (only for databases that support them)
-            let supportsSchemas = [DatabaseType.postgresql, .redshift, DatabaseType(rawValue: "Oracle"), DatabaseType(rawValue: "SQL Server")]
+            let supportsSchemas = [DatabaseType.postgresql, .redshift, .oracle, .mssql]
             if supportsSchemas.contains(databaseType) {
                 do {
                     let schemas = try await driver.fetchSchemas()