refactor: self-describing plugin system — zero core changes for new drivers

Author: datlechin

TablePro/AppDelegate+ConnectionHandler.swift

@@ -141,7 +141,7 @@ extension AppDelegate {
         let connectionName = url.deletingPathExtension().lastPathComponent
 
         for (sessionId, session) in DatabaseManager.shared.activeSessions {
-            if session.connection.type == .duckdb
+            if session.connection.type == DatabaseType(rawValue: "DuckDB")
                 && session.connection.database == filePath
                 && session.driver != nil {
                 bringConnectionWindowToFront(sessionId)
@@ -155,7 +155,7 @@ extension AppDelegate {
             port: 0,
             database: filePath,
             username: "",
-            type: .duckdb
+            type: DatabaseType(rawValue: "DuckDB")
         )
 
         openNewConnectionWindow(for: connection)

TablePro/AppDelegate+FileOpen.swift

@@ -66,7 +66,7 @@ extension AppDelegate {
                     switch dbType {
                     case .sqlite:
                         self.handleSQLiteFile(url)
-                    case .duckdb:
+                    case DatabaseType(rawValue: "DuckDB"):
                         self.handleDuckDBFile(url)
                     default:
                         self.handleGenericDatabaseFile(url, type: dbType)

TablePro/Core/Database/DatabaseDriver.swift

@@ -362,15 +362,15 @@ enum DatabaseDriverFactory {
         }
 
         switch connection.type {
-        case .mongodb:
+        case DatabaseType(rawValue: "MongoDB"):
             fields["sslCACertPath"] = ssl.caCertificatePath
             fields["mongoReadPreference"] = connection.mongoReadPreference ?? ""
             fields["mongoWriteConcern"] = connection.mongoWriteConcern ?? ""
-        case .redis:
+        case DatabaseType(rawValue: "Redis"):
             fields["redisDatabase"] = String(connection.redisDatabase ?? 0)
-        case .mssql:
+        case DatabaseType(rawValue: "SQL Server"):
             fields["mssqlSchema"] = connection.mssqlSchema ?? "dbo"
-        case .oracle:
+        case DatabaseType(rawValue: "Oracle"):
             fields["oracleServiceName"] = connection.oracleServiceName ?? ""
         default:
             break

TablePro/Core/Database/DatabaseManager.swift

@@ -803,7 +803,7 @@ final class DatabaseManager {
         driver: DatabaseDriver
     ) async -> String? {
         // Only needed for PostgreSQL PK modifications
-        guard databaseType == .postgresql || databaseType == .redshift || databaseType == .duckdb else { return nil }
+        guard databaseType == .postgresql || databaseType == .redshift || databaseType == DatabaseType(rawValue: "DuckDB") else { return nil }
         guard
             changes.contains(where: {
                 if case .modifyPrimaryKey = $0 { return true }

TablePro/Core/Plugins/PluginManager.swift

@@ -251,15 +251,27 @@ final class PluginManager {
                 Self.logger.error("Plugin '\(pluginId)' driver rejected: \(error.localizedDescription)")
             }
             if !driverPlugins.keys.contains(type(of: driver).databaseTypeId) {
-                let typeId = type(of: driver).databaseTypeId
+                let driverType = type(of: driver)
+                let typeId = driverType.databaseTypeId
                 driverPlugins[typeId] = driver
-                for additionalId in type(of: driver).additionalDatabaseTypeIds {
+                for additionalId in driverType.additionalDatabaseTypeIds {
                     driverPlugins[additionalId] = driver
                 }
 
-                // Built-in defaults are pre-populated in PluginMetadataRegistry.init().
-                // Runtime-loaded plugins may be compiled against an older TableProPluginKit,
-                // so we don't read new protocol properties from them to avoid witness table crashes.
+                // Self-register plugin metadata from the DriverPlugin protocol
+                let driverInstance = driver.createDriver(config: DriverConnectionConfig(
+                    host: "", port: 0, username: "", password: "", database: ""
+                ))
+                let snapshot = PluginMetadataRegistry.shared.buildMetadataSnapshot(
+                    from: driverType,
+                    isDownloadable: driverType.isDownloadable,
+                    parameterStyle: driverInstance.parameterStyle
+                )
+                PluginMetadataRegistry.shared.register(snapshot: snapshot, forTypeId: typeId)
+                for additionalId in driverType.additionalDatabaseTypeIds {
+                    PluginMetadataRegistry.shared.register(snapshot: snapshot, forTypeId: additionalId)
+                    PluginMetadataRegistry.shared.registerTypeAlias(additionalId, primaryTypeId: typeId)
+                }
 
                 Self.logger.debug("Registered driver plugin '\(pluginId)' for database type '\(typeId)'")
                 registeredAny = true