Behavior changes for NULL, TRUE and FALSE, and HTML5 support in rendering result
#1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rendering result.
mbrodala
suggested changes
Sep 5, 2025
src/Core/ViewHelper/TagBuilder.php
Outdated
| * I'd prefer to set the default value to FALSE. | ||
| * Maybe we can leave it to AbstractTagBasedViewHelper in TYPO3 | ||
| */ | ||
| protected bool $isXHtml = true; |
Contributor
There was a problem hiding this comment.
If at all this flag should be named requireAttributeValues or similar to clearly indicate its purpose. See the other single-purpose flags above.
Contributor
|
Let's address these issues separately. I think it makes sense to evaluate if we can deal with |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1227