[BUGFIX] Do not resolve TypoScriptConfiguration for deleted page in WS#4603
Open
amirarends wants to merge 1 commit intoTYPO3-Solr:mainfrom
Open
[BUGFIX] Do not resolve TypoScriptConfiguration for deleted page in WS#4603amirarends wants to merge 1 commit intoTYPO3-Solr:mainfrom
amirarends wants to merge 1 commit intoTYPO3-Solr:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pr does
When publishing a workspace that contains a deleted page,
ConfigurationManager::getTypoScriptConfiguration()was called with the $contextPageId of the deleted page. Without checking whether the page still exists, the code immediately calledSiteFinder::getSiteByPageId(), which throws an exception because the live record is gone. This interrupted theentire workspace publish process.A unit test covering the deleted-page scenario is included.
How to test
Fixes: #4602