[TASK] Refactor RoutingService and Middleware for improvements#4590
Open
froemken wants to merge 3 commits intoTYPO3-Solr:mainfrom
Open
[TASK] Refactor RoutingService and Middleware for improvements#4590froemken wants to merge 3 commits intoTYPO3-Solr:mainfrom
froemken wants to merge 3 commits intoTYPO3-Solr:mainfrom
Conversation
- Remove unnecessary `withSettings` method in `RoutingService`. - Refactor `SolrRoutingMiddleware`: - Introduce constructor property promotion. - Replace traits with dependency injection for `LoggerInterface`. - Revise context resolution logic for better readability and testability. - Simplify parameter extraction and route handling. - Add new `SolrRoutingContext` class for routing context encapsulation. - Update `PageIndexerRequestHandler` and `PageIndexerInitialization`: - Simplify code using constructor property promotion. - Extract helper methods for clarity and deduplication. - Adjust `Services.yaml` to exclude additional classes from autoloading. - Improve middleware unit tests to leverage `GeneralUtility::addInstance`.
- Define middleware services with namespace and resource path. - Enable `autowire` and `autoconfigure` for easier dependency injection.
- Remove redundant type declaration for `$responseOutputHandler`. - Align code with updated PHP typing standards for improved clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withSettingsmethod inRoutingService.SolrRoutingMiddleware:LoggerInterface.SolrRoutingContextclass for routing context encapsulation.PageIndexerRequestHandlerandPageIndexerInitialization:Services.yamlto exclude additional classes from autoloading.GeneralUtility::addInstance.