Conversation
modify fstring for python3.11 compatibility; is_tll to mtd_kde for more KDE to come.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the code to improve Python 3.11 compatibility and renames the parameter is_tll to mtd_kde, along with associated documentation and tests.
- Updated function signatures and docstrings to replace is_tll with mtd_kde.
- Modified project metadata and workflows to target Python 3.11.
- Adjusted examples and tests to reflect the new parameter naming and added plt.close calls in test cleanups.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| torchvinecopulib/vinecop/init.py | Renamed is_tll to mtd_kde and updated related f-string formatting. |
| torchvinecopulib/bicop/init.py | Replaced is_tll parameter with mtd_kde; note potential type annotation issue. |
| tests/.py, examples/, .github/workflows/*, README.md, pyproject.toml | Updated test calls, examples, workflows, and docs for the new parameter and Python version change. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
typo annotation, bool -> str Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modify f-string for python3.11 compatibility;
is_tll to mtd_kde for more KDE to come.