Skip to content

python3.11 compatibility; is_tll to mtd_kde#39

Merged
TY-Cheng merged 2 commits intomainfrom
dev_python3.11
Jun 18, 2025
Merged

python3.11 compatibility; is_tll to mtd_kde#39
TY-Cheng merged 2 commits intomainfrom
dev_python3.11

Conversation

@TY-Cheng
Copy link
Owner

modify f-string for python3.11 compatibility;
is_tll to mtd_kde for more KDE to come.

modify fstring for python3.11 compatibility;
is_tll to mtd_kde for more KDE to come.
@TY-Cheng TY-Cheng requested a review from Copilot June 18, 2025 03:08
@TY-Cheng TY-Cheng self-assigned this Jun 18, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the code to improve Python 3.11 compatibility and renames the parameter is_tll to mtd_kde, along with associated documentation and tests.

  • Updated function signatures and docstrings to replace is_tll with mtd_kde.
  • Modified project metadata and workflows to target Python 3.11.
  • Adjusted examples and tests to reflect the new parameter naming and added plt.close calls in test cleanups.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

File Description
torchvinecopulib/vinecop/init.py Renamed is_tll to mtd_kde and updated related f-string formatting.
torchvinecopulib/bicop/init.py Replaced is_tll parameter with mtd_kde; note potential type annotation issue.
tests/.py, examples/, .github/workflows/*, README.md, pyproject.toml Updated test calls, examples, workflows, and docs for the new parameter and Python version change.

@codacy-production
Copy link

codacy-production bot commented Jun 18, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.10% (target: -1.00%) 87.50%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bd656a4) 907 877 96.69%
Head commit (83cce29) 909 (+2) 878 (+1) 96.59% (-0.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#39) 8 7 87.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

typo annotation, bool -> str

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@TY-Cheng TY-Cheng merged commit 958f51f into main Jun 18, 2025
12 checks passed
@TY-Cheng TY-Cheng deleted the dev_python3.11 branch June 18, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant