Open
Conversation
|
The PR should follow certain rules. Most importantly a PR must be descriptive. This means that you need to describe a problem you are trying to solve (or feature you are trying to add) and in general terms explain how you solve it. The title of the pull request also must be descriptive. |
planetA
requested changes
Feb 21, 2023
| size_t metrics; // metrics count | ||
| double *data; // pointer to the malloc'ed data block, matrix is transposed | ||
| struct matrix full; // pointers to the matrix in its original form with all columns | ||
| struct matrix full; // pointers to the matrix in its original form with all columns 指向具有所有列的原始形式的矩阵的指针 |
There was a problem hiding this comment.
Do not put comments in Chinese in a repo that is supposed to be widely accessible.
| const size_t index_last = llsp->good.columns - 1; | ||
|
|
||
| free(llsp->good.matrix[index_last]); | ||
| // fprintf(stderr, "good.matrix = %p, index_last = %lu\n", llsp->good.matrix, index_last); |
There was a problem hiding this comment.
This is a comment left from "printf-debugging" now it serves no purpose. Remove it.
| llsp->metrics = count; | ||
| llsp->full.columns = count + 1; | ||
| llsp->sort.columns = count + 1; | ||
| llsp->good.columns = count + 1; |
| free(llsp->good.matrix[index_last]); | ||
| // fprintf(stderr, "good.matrix = %p, index_last = %lu\n", llsp->good.matrix, index_last); | ||
| if (llsp->good.matrix) { | ||
| free(llsp->good.matrix[index_last]); |
There was a problem hiding this comment.
Shouldn't there be some loop over all columns? Not just the last one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.