Port template to .NET 9 and update to TShock version 6#5
Open
64Terabytes wants to merge 2 commits intoTShockResources:masterfrom
Open
Port template to .NET 9 and update to TShock version 6#564Terabytes wants to merge 2 commits intoTShockResources:masterfrom
64Terabytes wants to merge 2 commits intoTShockResources:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated target framework to .NET 9 and TShock package reference to version 6. I recreated and compiled the server hooks example with this template, and had no noticeable issues.
I also updated the documentation link in the readme to go directly to the github wiki instead of redirecting, this may not be needed.
I kept the readme wiki link despite it being heavily outdated since the TShock wiki link doesn't have a developer docs section (that I have noticed).
This is my first time making a contribution to a large project like TShock, and my first time working with .NET. I would appreciate any feedback if you have any <3