Allow to change SatNav Locations location while seated#3
Open
Merl wants to merge 7 commits intoTROG111:mainfrom
Open
Allow to change SatNav Locations location while seated#3Merl wants to merge 7 commits intoTROG111:mainfrom
Merl wants to merge 7 commits intoTROG111:mainfrom
Conversation
* reformated README.md * the DimHud integration now reloads SavedLocations allowing to change the SatNav target without leaving the seat
Owner
|
Actually the 'old' code (from the rad me file updated the location in Dim Hud every time the tick occured (if it had changed) so I am not really sure what you are talking about, unless you hadnt updated your integration code to match the code provided in the readme file; So I am not really following what you are suggesting? Although your DimHud integrtion code looks good. Looked at your integration code a bit more and I honestly dont see what it is trying to achieve, perhaps you could explain it? As far as I can see, my existing integration code should work fine. |
Added hint to official Repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As SatNav now uses a fixed name for the location the old code did only update the autopilot target once.
I modified the code that goes into DimHUD to reload the SavedLocations from the databank if they got modified by SatNav.
The changes are in README.md only. I modified the markdown a little for readability too.
The rest of the changes are just re-ordering to my personal preferences and updateing the source to reflect what is in the current JSON and can be ignored.
Please feel free to cherry-pick what you like.