Upgrade to Gradle 9 #85
Conversation
Signed-off-by: Jonas Höf <jonas.hoef@tngtech.com>
Signed-off-by: Jonas Höf <jonas.hoef@tngtech.com>
Remove by now obsolete clean task. Signed-off-by: Jonas Höf <jonas.hoef@tngtech.com>
Signed-off-by: Jonas Höf <jonas.hoef@tngtech.com>
Signed-off-by: Jonas Höf <jonas.hoef@tngtech.com>
Avoid Javadoc lint warnings regardless of Java version. Add default Java version 21. Signed-off-by: Jonas Höf <jonas.hoef@tngtech.com>
aaschmid
left a comment
aaschmid
left a comment
There was a problem hiding this comment.
Changes look good, however, haven't tested it, yet.
| apply plugin: 'signing' | ||
| releaseProjects*.with { | ||
| tasks.withType(GenerateModuleMetadata).configureEach { | ||
| enabled = false // the meta-data does not match the way the Maven artifacts are composed and thus is broken |
There was a problem hiding this comment.
Maybe some more explanation about the problem such that other can reproduce later?
There was a problem hiding this comment.
AFAIK this was copied from another TNG open source project when first publishing the value-provider on Maven Central. I have to admit that I did not analyze any further. In the junit-dataprovider build.gradle.kts there is a comment regarding problems only with SNAPSHOT versions. So if you have additional information I would be glad to adapt.
| tasks.withType(PublishToMavenRepository).configureEach { | ||
| it.doFirst { | ||
| assert !gradle.startParameter.isParallelProjectExecutionEnabled(): | ||
| 'uploading archives with parallel execution seems to lead to broken uploads in Maven Central' |
There was a problem hiding this comment.
Is this still the case or fixed meanwhile?
There was a problem hiding this comment.
To be honest, I don't know, but I don't want to take a risk, as the benefits of a parallel publishing are negligible for 3 jars.
…creation including manifest, license etc to normal build rather than restricting it to release builds Requires to switch off implicit Javadoc creation of vanniktech plugin. Signed-off-by: Jonas Höf <jonas.hoef@tngtech.com>
The vanniktech publish plugin creates the Javadoc jar by default, but as opposed to the Javadoc jar created via the standard
withJavadocJar(), it doesn't contain a decentMANIFEST.MFandLICENSEfiles. Therefore, the vanniktech plugin must be configured to prevent Javadoc jar creation, but publish the one created via the standardwithJavadocJar().