Cleanup and Documentation #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luis Augenstein <luis.augenstein@tngtech.com>
augelu-tng
force-pushed
the
improve-documentation
branch
2 times, most recently
from
3a16a1b to
1db99ff
Compare
gregkh
reviewed
Dec 17, 2025
gregkh
left a comment
gregkh
left a comment
There was a problem hiding this comment.
Please keep a copyright line, that's fine, it's just this format that is not very commonly used in the kernel at this point in time.
Contributor
Author
|
How should I do it then ? |
|
That matches what most people/companies do, so yes, that looks fine. |
augelu-tng
force-pushed
the
improve-documentation
branch
2 times, most recently
from
59d8291 to
68e34d8
Compare
gregkh
suggested changes
Dec 17, 2025
| def _build_file_element( | ||
| absolute_path: PathStr, name: str, spdx_id: SpdxId, file_location: KernelFileLocation | ||
| ) -> File: | ||
| def _build_file_element(absolute_path: PathStr, name: str, spdx_id: SpdxId, file_location: KernelFileLocation) -> File: |
sbom/sbom/spdx_graph/kernel_file.py
Outdated
| kernel_file = KernelFile.create( | ||
| node.absolute_path, obj_tree, src_tree, spdx_id_generators, is_root | ||
| ) | ||
| kernel_file = KernelFile.create(node.absolute_path, obj_tree, src_tree, spdx_id_generators, is_root) |
sbom/README
Outdated
|
|
||
| $ python3 tools/sbom/sbom.py --help | ||
|
|
||
|
|
sbom/sbom/spdx_graph/kernel_file.py
Outdated
| file_location == KernelFileLocation.SOURCE_TREE | ||
| or file_location == KernelFileLocation.BOTH | ||
| ) | ||
| if (file_location == KernelFileLocation.SOURCE_TREE or file_location == KernelFileLocation.BOTH) |
| sbom_logging.warning( | ||
| "Could not infer primary purpose for {absolute_path}", absolute_path=absolute_path | ||
| ) | ||
| sbom_logging.warning("Could not infer primary purpose for {absolute_path}", absolute_path=absolute_path) |
Contributor
Author
There was a problem hiding this comment.
Sorry for mixing up the changes.
Cleaned it up now.
…T license identifier Signed-off-by: Luis Augenstein <luis.augenstein@tngtech.com>
Signed-off-by: Luis Augenstein <luis.augenstein@tngtech.com>
Signed-off-by: Luis Augenstein <luis.augenstein@tngtech.com>
augelu-tng
force-pushed
the
improve-documentation
branch
from
68e34d8 to
600e4db
Compare
Signed-off-by: Luis Augenstein <luis.augenstein@tngtech.com>
augelu-tng
force-pushed
the
improve-documentation
branch
from
600e4db to
5cc5222
Compare
gregkh
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.