Add com.tngtech.archunit.openrewrite.SanityCheck
#1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
spotless-fix-sanity-check
branch
from
cbb6120 to
1c167dd
Compare
Pankraz76
commented
Dec 9, 2025
| } | ||
|
|
||
| private Path[] modulepath() { | ||
| String modulepathProperty = nullToEmpty(System.getProperty("jdk.module.path")); |
Author
There was a problem hiding this comment.
this change was done by me as somehow here an random compile issue emerged.
This class is actually pretty nice structured having no coupling actually, all the references technically obsolete.
| String modulepathProperty = nullToEmpty(System.getProperty("jdk.module.path")); | ||
| List<String> modulepath = Splitter.on(File.pathSeparatorChar).omitEmptyStrings().splitToList(modulepathProperty); | ||
| return modulepath.stream().map(Paths::get).toArray(Path[]::new); | ||
| return Splitter |
Author
There was a problem hiding this comment.
Following SoC SRP the code could have 100% cohesion, instead of 100% coupling overhead.
When refining the code this seems to be the final version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
com.tngtech.archunit.openrewrite.SanityCheckconsidering all the other changes im impressed and wondered about the few changes.
related to:
org.junit.openrewrite.SanityCheckjunit-team/junit-framework#5193error-prone.picnic.tech/bugpatterns/NonStaticImportjunit-team/junit-framework#5191SanityCheckfeaturingCommonStaticAnalysisdiffplug/spotless#2651UpgradeToJava17diffplug/spotless#2636