Open
Conversation
- Updating metadata.properties and metadata_lc.properties files to hide internal schemas from external JDBC Tools.
snappy-sachin
commented
Mar 25, 2020
| CAST(NULL AS VARCHAR(128)) AS TABLE_CATALOG \ | ||
| FROM SYS.HIVETABLES \ | ||
| WHERE SCHEMANAME LIKE ? \ | ||
| AND SCHEMANAME NOT IN ('NULLID', 'SNAPPY_HIVE_METASTORE','SQLJ','SYSCAT', \ |
Author
There was a problem hiding this comment.
Hi Neeraj,
I have added check for internal schema names in SYS.HIVETABLES query also. Is it really required ?
sumwale
force-pushed
the
snappy/master
branch
2 times, most recently
from
337768c to
ec453a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
to hide internal schemas from external JDBC Tools.
Patch testing
Is precheckin with -Pstore clean?
ReleaseNotes changes
(Does this change require an entry in ReleaseNotes? If yes, has it been added to it?)
Other PRs