Fix for SNAP-2620. New branch created. SNAP-2620 will be deleted.#484
Merged
kneeraj merged 4 commits intosnappy/masterfrom Jul 19, 2019
Merged
Fix for SNAP-2620. New branch created. SNAP-2620 will be deleted.#484kneeraj merged 4 commits intosnappy/masterfrom
kneeraj merged 4 commits intosnappy/masterfrom
Conversation
Conflicts: gemfirexd/core/src/main/java/com/pivotal/gemfirexd/internal/engine/access/index/GfxdIndexManager.java
suranjan
reviewed
Jul 19, 2019
| } | ||
|
|
||
| protected String reduceLogging() { | ||
| return "fine"; |
sumwale
pushed a commit
to sumwale/snappy-store
that referenced
this pull request
Apr 30, 2021
…BCOSoftware#484) * Fix for SNAP-2620. Wrong unique index violation error in the scenario mentioned in SNAP-2620.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The fix is to replace the wrapper, which indicates delete done by the same
transaction, by the gfxd tx entry. During rollback however we would have to
reinstate the committed region entry which was there before this transaction.
Original PR (#434) filed will be closed as the code was not merged properly there. Easier was to create another branch than to fix that.
Reviewer please look at some comment made in the original PR also and let me know if you have questions.
Patch testing
Added dunit for the same for both RR and RC mode
Is precheckin with -Pstore clean?
Yes.
ReleaseNotes changes
None.
Other PRs
None.