fix: add configurable models for tts and asr#50
Open
ShaojieLiu wants to merge 1 commit intoTHU-MAIC:mainfrom
Open
fix: add configurable models for tts and asr#50ShaojieLiu wants to merge 1 commit intoTHU-MAIC:mainfrom
ShaojieLiu wants to merge 1 commit intoTHU-MAIC:mainfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds configurable model support for TTS and ASR.
Previously, TTS and ASR provider implementations used hardcoded server-side models, so the settings UI could not choose which model to use. This change introduces persisted
ttsModelIdandasrModelIdsettings, updates the TTS/ASR configuration pages to follow the image-generation model-management pattern, and propagates the selected model through preview, generation, and transcription flows.Related Issues
Fixes the issue where TTS and ASR could not select models independently in settings.
closed #14
Changes
ttsModelIdandasrModelIdto persisted settings stateType of Change
Verification
Steps to reproduce / test
What you personally verified
Ran targeted
eslintchecks on modified filesRan
pnpm exec tsc -p tsconfig.json --noEmitVerified the TTS/ASR settings UI structure now mirrors the image-generation model section
Verified selected TTS/ASR model IDs are threaded through client requests into server handlers
Did not run full manual browser interaction testing or full CI suite in this session
pnpm exec eslint lib/audio/types.ts lib/audio/constants.ts lib/store/settings.ts lib/audio/tts-providers.ts lib/audio/asr-providers.ts app/api/generate/tts/route.ts app/api/transcription/route.ts components/settings/tts-settings.tsx components/settings/asr-settings.tsx components/generation/media-popover.tsx components/audio/tts-config-popover.tsx lib/hooks/use-audio-recorder.ts lib/hooks/use-scene-generator.ts app/generation-preview/page.tsxpnpm exec tsc -p tsconfig.json --noEmitEvidence
pnpm check && pnpm lint && npx tsc --noEmit)Checklist