Feat: allow admin to manage when the users need to login from specific_ip.Ip time range #207

yushiuan9499 · 2026-01-26T03:24:52Z

Added

A manage UI that allow admin to add/update/delete time slots, and inspect the informations. The UI is based on TUI calendar.
In UserService.sign_in(), it must be weekday to block users if the ip doesn't match specific_ip.
HolidayService
- Support add/delete time slots with priority & is_weekday type, and query is_weekday at given datetime.
- Automatically fetch schedule from government's API & school's calendar.

Changed

Because the condition to block user's ip is changed, the tests for UserService also change a bit.

These functions allow admin insert a weekdays range, update a weekdays range exists, delete a weekdays range exists, and delete all weekdays range in given range.

If there are adjacent events with higher priority within the range inserted, some event with zero duration will be inserted into DB. These data are redundant.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 14 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/handlers/manage/holiday.py

src/services/holiday.py

src/static/templ/manage/holiday.html

src/services/holiday.py

src/tests/unit/services/test_user.py

src/services/holiday.py

src/static/templ/manage/holiday.html

The original one seems to have some problem with CORS. This causes browsers fail to check integrity.

My fault.

yushiuan9499 added 30 commits January 18, 2026 13:23

feat(services): update & delete weekdays

5b64873

These functions allow admin insert a weekdays range, update a weekdays range exists, delete a weekdays range exists, and delete all weekdays range in given range.

feat(services): fetch gov holiday data before get_weeks

2ae5346

feat(holiday): add holiday page

f0debcb

fix(holiday): add priority and is_weekday

3eea2b0

feat(holiday): fetch data from school's calendar

c67b4e4

feat(holiday): add basic calendar

428bac8

fix(holiday): get_days not return is_weekday

ea09d97

migration: create tables to record weekdays & fetch status

33a568a

fix(holiday): get_days take range as param

59e0414

fix(holiday): get_days not return err

eff52f6

fix(holiday): remove debug console.log

0b55d13

fix(holiday): service not inited

bd05256

fix(holiday): fix redis bug

d4c2358

fix(holiday): typo of isholiday

6521446

fix(holiday): the logic of avoiding higher priority

56af3ec

feat(holiday): get holiday&weekday range from backend

2f11f51

fix: typo

9920ecd

fix(holiday): add days doesn't check pri&is_weekday

ba750cc

fix(holiday): redis.get return bytes

d6326ee

fix(holiday): redis.get return bytes

3feaced

fix(holiday): the end of winter&summer has hour&minute

b2e2f97

fix(holiday): remove zero range event

548ae2b

If there are adjacent events with higher priority within the range inserted, some event with zero duration will be inserted into DB. These data are redundant.

fix(holiday): redundant continue

22d9eeb

fix(templ): calendar's height may become very low

a88cf7a

feat(templ): add date picker to change month

00efd6c

feat(templ): update & delete event

0c62ffe

feat(handler): update & delete event

b939437

style(holiday): rename method

1c69cac

feat(holiday): add time slot by click calendar

09f5d30

fix(templ): always hide modal when recieve res

ee35c4b

tobiichi3227 assigned yushiuan9499 Jan 26, 2026

ChenKaiLiuG approved these changes Jan 27, 2026

View reviewed changes

yushiuan9499 added 3 commits January 27, 2026 13:52

fix: remove import of requests

73dd6df

fix: add error log

413a616

fix: store magic number in const & add comment

12900c6

yushiuan9499 force-pushed the ip-time-range branch from f53bd17 to 12900c6 Compare January 27, 2026 06:31

tobiichi3227 requested a review from Copilot January 27, 2026 06:55

Copilot started reviewing on behalf of tobiichi3227 January 27, 2026 06:55 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

yushiuan9499 added 6 commits January 27, 2026 15:46

fix(holiday): use transaction

0334871

fix(holiday): fix minor bugs

8857bc6

fix(holiday): add tzinfo if None & add timedelta to date

e2cbe9a

fix(test_user): use AsynMock on async func

7649fde

fix(holiday): url of fetch_school_data contain invalid char

90dc899

fix(templ): integrity & destroy

fb8b5ca

yushiuan9499 requested a review from tobiichi3227 January 27, 2026 08:51

fix(templ): wrong integrity

42d88e2

tobiichi3227 requested changes Jan 27, 2026

View reviewed changes

src/static/templ/manage/holiday.html Outdated Show resolved Hide resolved

tobiichi3227 mentioned this pull request Jan 27, 2026

缺曠課連結課表功能 tobiichi3227/TNFSH-Scoreboard#19

Open

tobiichi3227 requested changes Jan 28, 2026

View reviewed changes

src/static/templ/manage/holiday.html Show resolved Hide resolved

yushiuan9499 and others added 8 commits January 28, 2026 20:09

fix(holiday): % character in strftime

7dc8965

fix(templ): change cdn of tui-calendar

2439358

The original one seems to have some problem with CORS. This causes browsers fail to check integrity.

fix(templ): add bootstrap class on radio

4637ad3

fix(templ): wrong div location

ffbf91a

My fault.

fix(templ): position of month picker is wrong

8aed2c6

impr(templ): close month picker when click year-month text

0dbfbfa

impr(templ): make year-month text cannot select

865364a

Merge branch 'tnfsh' into ip-time-range

6d376ef

tobiichi3227 approved these changes Jan 31, 2026

View reviewed changes

tobiichi3227 merged commit e834b6f into TFcis:tnfsh Jan 31, 2026
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: allow admin to manage when the users need to login from specific_ip.Ip time range #207

Feat: allow admin to manage when the users need to login from specific_ip.Ip time range #207

yushiuan9499 commented Jan 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Feat: allow admin to manage when the users need to login from specific_ip.Ip time range #207

Feat: allow admin to manage when the users need to login from specific_ip.Ip time range #207

Conversation

yushiuan9499 commented Jan 26, 2026

Added

Changed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants