most oddDecl elements must be descendant of <schemaSpec> or <specGrp>#2855
Open
most oddDecl elements must be descendant of <schemaSpec> or <specGrp>#2855
<schemaSpec> or <specGrp>#2855Conversation
issue #2306. Still have to write tests.
elementSpec-should-not-be-in-head.
Contributor
|
With @sydb and @HelenaSabel : We tested this and determined that there are 981 cases that violate these constraints within p5subset.xml (spec elements are children of divs there). Therefore we chose to postpone this merge until after the February release, so that we can also add wrapping specGrps to make p5subset.xml valid (for which another ticket already exists), and check that there's no fallout from that change in the Stylesheets ODD processing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #2306 by:
<classSpec>,<constraintSpec>,<dataSpec>,<elementSpec>,<macroSpec>,<outputRendition>, or<specGrpRef>is not inside a<schemaSpec>, a<specGrp>, or a<egXML>(due to testing-swaps-namespace thing).<specGrp><elementSpec>-inside-<head>)In 9–10 months time the deprecation warning should become an error.
Note: This is currently a DRAFT PR, as I have not yet added a note to Appendix G (deprecations). Hope to get to that tonight, but figure the rest can be looked at without that.