Open
Conversation
extracted StatusIndicator from badge
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
airikej
reviewed
Mar 13, 2026
airikej
reviewed
Mar 13, 2026
airikej
reviewed
Mar 13, 2026
airikej
reviewed
Mar 13, 2026
| url: 'https://www.figma.com/design/jWiRIXhHRxwVdMSimKX2FF/TEDI-READY-2.38.59?node-id=2405-53326&m=dev', | ||
| }, | ||
| }, | ||
| argTypes: { |
Contributor
There was a problem hiding this comment.
i think these are generated automatically, you should be able to remove them
Contributor
Author
There was a problem hiding this comment.
by default it added just a string type without any selectable values. Could it be achieved without defining argTypes?
Contributor
There was a problem hiding this comment.
ah i see the problem, it does that because you define separate types e.g
export type StatusIndicatorType = 'success' | 'danger' | 'warning' | 'inactive';
export type StatusIndicatorSize = 'sm' | 'lg';
export type StatusIndicatorPosition = 'default' | 'top-right';
and then assign it like
statusIndicatorPosition: StatusIndicatorPosition
but if you add it like this:
statusIndicatorPosition: default' | 'top-right'
then it shows the selection
no idea how to fix that though
code review fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted StatusIndicator from badge