Skip to content

feat(tabs): new tedi-ready component #555#557

Open
mart-sessman wants to merge 3 commits intorcfrom
feat/555-tabs-tedi-ready
Open

feat(tabs): new tedi-ready component #555#557
mart-sessman wants to merge 3 commits intorcfrom
feat/555-tabs-tedi-ready

Conversation

@mart-sessman
Copy link
Contributor

extracted StatusIndicator from badge

extracted StatusIndicator from badge
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 96.47887% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ts/navigation/tabs/tabs-dropdown/tabs-dropdown.tsx 93.54% 2 Missing ⚠️
...rc/tedi/components/navigation/tabs/tabs-helpers.ts 92.59% 2 Missing ⚠️
...c/tedi/components/navigation/tabs/tabs-context.tsx 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

url: 'https://www.figma.com/design/jWiRIXhHRxwVdMSimKX2FF/TEDI-READY-2.38.59?node-id=2405-53326&m=dev',
},
},
argTypes: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think these are generated automatically, you should be able to remove them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default it added just a string type without any selectable values. Could it be achieved without defining argTypes?

Copy link
Contributor

@airikej airikej Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see the problem, it does that because you define separate types e.g

export type StatusIndicatorType = 'success' | 'danger' | 'warning' | 'inactive';
export type StatusIndicatorSize = 'sm' | 'lg';
export type StatusIndicatorPosition = 'default' | 'top-right';

and then assign it like
statusIndicatorPosition: StatusIndicatorPosition
but if you add it like this:
statusIndicatorPosition: default' | 'top-right'
then it shows the selection

no idea how to fix that though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants