Skip to content

fix(card): fix card padding overrides, add padding to tab content #184 #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pesarv merged 1 commit into from
Mar 18, 2026
Merged

fix(card): fix card padding overrides, add padding to tab content #184 #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 44 additions & 32 deletions community/components/cards/card/_card-mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,33 @@ $card-colors: (
);

$card-spacings: ("xs", "sm", "md", "lg", "none");
$spacing-directions: (
"vertical",
"horizontal",
"top",
"bottom",
"left",
"right"
$class-properties: (
"": (
"top",
"bottom",
"left",
"right",
),
"-vertical": (
"top",
"bottom",
),
"-horizontal": (
"left",
"right",
),
"-top": (
"top",
),
"-bottom": (
"bottom",
),
"-left": (
"left",
),
"-right": (
"right",
),
);

$accent-border-colors: (
Expand Down Expand Up @@ -70,46 +90,38 @@ $accent-border-colors: (
}
}

@mixin card-spacing-value($spacing, $direction: null) {
// css private variable name
$private-var-name: if(
$direction,
--_card-padding-#{$direction},
--_card-padding
);

@mixin card-spacing-value($spacing, $direction) {
// assigns TEDI variable to private variable, 0 if none
@if ($spacing == "none") {
#{$private-var-name}: 0;
--_card-padding-#{$direction}: 0;
} @else {
$tedi-var-name: if($spacing== "md", "md-default", $spacing);
#{$private-var-name}: var(--card-padding-#{$tedi-var-name});
--_card-padding-#{$direction}: var(--card-padding-#{$tedi-var-name});
}
}

@mixin card-spacings {
@each $spacing in $card-spacings {
&--spacing-#{$spacing} {
@include card-spacing-value($spacing);
@each $direction in ("top", "bottom", "left", "right") {
@include card-spacing-value($spacing, $direction);
}
}
}
}

@mixin card-padding-overrides {
& {
--_card-padding-vertical: var(--_card-padding);
--_card-padding-horizontal: var(--_card-padding);
--_card-padding-top: var(--_card-padding-vertical);
--_card-padding-bottom: var(--_card-padding-vertical);
--_card-padding-left: var(--_card-padding-horizontal);
--_card-padding-right: var(--_card-padding-horizontal);
}
@mixin card-padding {
padding: var(--_card-padding-top, 0) var(--_card-padding-right, 0)
var(--_card-padding-bottom, 0) var(--_card-padding-left, 0);
}

@each $spacing in $card-spacings {
@each $direction in $spacing-directions {
&--padding-#{$direction}-#{$spacing},
&--padding-#{$spacing} {
@include card-spacing-value($spacing, $direction);
@mixin card-padding-overrides {
@each $class-suffix, $direction-properties in $class-properties {
@each $direction in $direction-properties {
@each $spacing in $card-spacings {
&--padding#{$class-suffix}-#{$spacing} {
@include card-spacing-value($spacing, $direction);
}
}
}
}
Expand Down
6 changes: 4 additions & 2 deletions community/components/cards/card/card-content/card-content.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
@use "../card-mixins";

.tedi-card-content {
display: block;
background-color: var(--_card-bg);
border: 1px solid var(--_card-border);
padding: var(--_card-padding-top) var(--_card-padding-right)
var(--_card-padding-bottom) var(--_card-padding-left);
@include card-mixins.card-padding;
@include card-mixins.card-padding-overrides;
flex: 1 1 0;

&--auto-width {
Expand Down
6 changes: 4 additions & 2 deletions community/components/cards/card/card-header/card-header.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
@use "../card-mixins";

.tedi-card-header {
border: 1px solid var(--_card-border);
background: var(--_card-bg);
padding: var(--_card-padding-top) var(--_card-padding-right)
var(--_card-padding-bottom) var(--_card-padding-left);
@include card-mixins.card-padding;
@include card-mixins.card-padding-overrides;

&--primary {
--_card-bg: var(--card-background-primary);
Expand Down
4 changes: 2 additions & 2 deletions community/components/cards/card/stories/card-story-templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,9 @@ export const renderCardPaddingsStory = () => {
Top LG
</tedi-card-header>

<tedi-card-header [padding]="'xs'">
<tedi-card-content [padding]="'xs'">
Full XS padding
</tedi-card-header>
</tedi-card-content>

<tedi-card-content background="secondary">
Parent has left XS, right NONE, Top NONE.
Expand Down
6 changes: 5 additions & 1 deletion community/components/navigation/tabs/tabs.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@
</div>
</tedi-card-content>

<tedi-card-content role="tabpanel" [attr.aria-labelledby]="activeTabId()">
<tedi-card-content
role="tabpanel"
[attr.aria-labelledby]="activeTabId()"
[padding]="{ horizontal: 'md', vertical: 'lg' }"
>
@if (activeTabContent(); as activeContent) {
<ng-container *ngTemplateOutlet="activeContent" />
}
Expand Down
Loading