Refactor: Extract Finalsite exclude IDs to intermediate model#3425
Open
anthonygwalters wants to merge 2 commits intomainfrom
Open
Refactor: Extract Finalsite exclude IDs to intermediate model#3425anthonygwalters wants to merge 2 commits intomainfrom
anthonygwalters wants to merge 2 commits intomainfrom
Conversation
Union stg_google_sheets__finalsite__exclude_ids with Google Form responses (form_id = '1iH4Cjy_RIc8TWJf6Ts0sxhpVmCnx4paiT5RSNOS2Rn4') using UNION DISTINCT to deduplicate exclude IDs from both sources. Update stg_finalsite__status_report to reference the new intermediate model. https://claude.ai/code/session_01E7WESstQxAcGY2ry66oPfN
Member
|
@anthonygwalters some context? are we migrating the sheet to a form? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary & Motivation
When merged, this pull request will refactor the Finalsite exclude IDs logic into a dedicated intermediate dbt model that combines data from both the Google Sheets staging table and Google Forms responses. This consolidates the exclude IDs logic in one place and makes it reusable across multiple models.
Changes:
int_google_sheets__finalsite__exclude_idsthat unions Finalsite student IDs from the staging table with IDs extracted from a specific Google Formstg_finalsite__status_reportto reference the new intermediate model instead of the staging table directlySelf-review
dbt
[model name].ymlproperties file for all modelsfinalsite_student_idcolumn withstore_failures: trueSQL
union distinctwith appropriate logic for combining two data sourcesgroup bywithout aggregationsorder byin select statementsTest Plan
Existing dbt tests will validate:
finalsite_student_idvalues in the new intermediate modelstg_finalsite__status_reportwhen filtering by the new modelhttps://claude.ai/code/session_01E7WESstQxAcGY2ry66oPfN